diff options
| author | Vicențiu Ciorbaru <vicentiu@mariadb.org> | 2017-06-28 18:42:56 +0300 |
|---|---|---|
| committer | Vicențiu Ciorbaru <vicentiu@mariadb.org> | 2017-06-28 19:21:31 +0300 |
| commit | 31ba0fa48d27715e82258b1e74401093e0ee17a2 (patch) | |
| tree | f4f4f6faa740c127d69cab064ad27fe58cdeacc8 /sql/item_func.cc | |
| parent | 23edc7c88f29d7bee01f39f1a58f4ada05f724c3 (diff) | |
| download | mariadb-git-31ba0fa48d27715e82258b1e74401093e0ee17a2.tar.gz | |
MDEV-12851: Case with window functions query crashes server
The "is null" function performs one operation which no other Item_func
does, which is to update used tables during fix_length_and_dec().
This however can not be performed before window functions have had a
chance to resolve their order by and partition by definitions, which
happens after the initial setup_fields call. Consequently, do not call
Item_func_isnull update_used_tables during fix_length_and_dec().
There was another issue detected once the crash was resolved.
Because window functions did not implement is_null() method, we would
end up returning bad results for "is null" and "is not null" functions.
Implemented is_null() method for Item_windowfunc.
Diffstat (limited to 'sql/item_func.cc')
| -rw-r--r-- | sql/item_func.cc | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/sql/item_func.cc b/sql/item_func.cc index 8529a1d08ca..1b83f86d19c 100644 --- a/sql/item_func.cc +++ b/sql/item_func.cc @@ -153,8 +153,9 @@ void Item_func::sync_with_sum_func_and_with_field(List<Item> &list) is to allow all Item_field() objects to setup pointers to the table fields. Sets as a side effect the following class variables: - maybe_null Set if any argument may return NULL - with_sum_func Set if any of the arguments contains a sum function + maybe_null Set if any argument may return NULL + with_sum_func Set if any of the arguments contains a sum function + with_window_func Set if any of the arguments contain a window function with_field Set if any of the arguments contains or is a field used_tables_cache Set to union of the tables used by arguments |