Fix for bug #4340: find_in_set is case insensitive even on binary operators(2nd version)

mysql-test/r/func_set.result:
  Fix for bug #4340: find_in_set is case insensitive even on binary operators
mysql-test/t/func_set.test:
  Fix for bug #4340: find_in_set is case insensitive even on binary operators
sql/item_func.cc:
  Fix for bug #4340: find_in_set is case insensitive even on binary operators

1 files changed, 19 insertions, 5 deletions

diff --git a/sql/item_func.cc b/sql/item_func.cc
index 237db890abb..334be48dc9a 100644
--- a/sql/item_func.cc
+++ b/sql/item_func.cc
@@ -1071,6 +1071,7 @@ static const char separator=',';
 
 longlong Item_func_find_in_set::val_int()
 {
+  bool binary_cmp= args[0]->binary || args[1]->binary;
   if (enum_value)
   {
     ulonglong tmp=(ulonglong) args[1]->val_int();
@@ -1103,12 +1104,25 @@ longlong Item_func_find_in_set::val_int()
     do
     {
       const char *pos= f_pos;
-      while (pos != f_end)
+      if (binary_cmp)
       {
-	if (toupper(*str) != toupper(*pos))
-	  goto not_found;
-	str++;
-	pos++;
+        while (pos != f_end)
+        {
+          if (*str != *pos)
+            goto not_found;
+          str++;
+          pos++;
+        }
+      }
+      else
+      {
+        while (pos != f_end)
+        {
+          if (toupper(*str) != toupper(*pos))
+            goto not_found;
+          str++;
+          pos++;
+        }
       }
       if (str == real_end || str[0] == separator)
 	return (longlong) position;