summaryrefslogtreecommitdiff
path: root/sql/item_strfunc.h
diff options
context:
space:
mode:
authorgkodinov/kgeorge@macbook.gmz <>2006-07-25 18:42:49 +0300
committergkodinov/kgeorge@macbook.gmz <>2006-07-25 18:42:49 +0300
commitf5b0dd6a002846a5c3d3bdc1651e51aad1ce2ddc (patch)
tree53a892a7220b9a860eccf699b7f47e576276c1d6 /sql/item_strfunc.h
parent9e9fb3e4e494bad69ce0ce668645e08d224809ee (diff)
downloadmariadb-git-f5b0dd6a002846a5c3d3bdc1651e51aad1ce2ddc.tar.gz
Bug #21086: server crashes when VIEW defined with a SELECT with COLLATE clause is called
When executing INSERT over a view with calculated columns it was assuming all elements of the fields collection are actually Item_field instances. This may not be true when inserting into a view and that view has columns that are such expressions that allow updating (like setting a collation for example). Corrected to access field information through the filed_for_view_update() function and retrieve correctly the field info even for "update-friendly" non-Item_field items.
Diffstat (limited to 'sql/item_strfunc.h')
-rw-r--r--sql/item_strfunc.h2
1 files changed, 1 insertions, 1 deletions
diff --git a/sql/item_strfunc.h b/sql/item_strfunc.h
index a72182abcf7..488dc20b063 100644
--- a/sql/item_strfunc.h
+++ b/sql/item_strfunc.h
@@ -728,7 +728,7 @@ public:
void fix_length_and_dec();
bool eq(const Item *item, bool binary_cmp) const;
const char *func_name() const { return "collate"; }
- enum Functype func_type() const { return COLLATE_FUNC; }
+ enum Functype functype() const { return COLLATE_FUNC; }
void print(String *str);
Item_field *filed_for_view_update()
{