diff options
author | Alexander Barkov <bar@mariadb.org> | 2016-01-16 18:45:26 +0400 |
---|---|---|
committer | Alexander Barkov <bar@mariadb.org> | 2016-01-16 18:45:26 +0400 |
commit | 7b50447aa6d051b8d14bb01ef14802cb8ffee223 (patch) | |
tree | 551c3240ca2ebb227ebc5735157e6d97b0ce6501 /sql/item_subselect.cc | |
parent | 98b6026036913bed65b6e121c86580ebd92bd715 (diff) | |
download | mariadb-git-7b50447aa6d051b8d14bb01ef14802cb8ffee223.tar.gz |
MDEV-9407 Illegal mix of collation when using GROUP_CONCAT in a VIEW
MDEV-9408 CREATE TABLE SELECT MAX(int_column) creates different columns for table vs view
There were three almost identical pieces of the code:
- Field *Item_func::tmp_table_field();
- Field *Item_sum::create_tmp_field();
- Field *create_tmp_field_from_item();
with a difference in very small details (hence the bugs):
Only Item_func::tmp_table_field() was correct, the other two were not.
Removing the two incorrect pieces of the redundant code.
Joining these three functions/methods into a single virtual method
Item::create_tmp_field().
Additionally, moving Item::make_string_field() and
Item::tmp_table_field_from_field_type() from the public into the
protected section of the class declaration, as they are now not
needed outside of Item.
Diffstat (limited to 'sql/item_subselect.cc')
0 files changed, 0 insertions, 0 deletions