after review fix

mysql-test/r/func_str.result:
  new results
sql/item.cc:
  charset changed
  printing string moved to String
sql/item_cmpfunc.cc:
  new comparation class builder to avoid long switch
  new print_agrs used
sql/item_cmpfunc.h:
  new comparation class builder to avoid long switch
sql/item_func.cc:
  new print_agrs
sql/item_func.h:
  new print_agrs
sql/item_strfunc.cc:
  new print_agrs
sql/item_subselect.cc:
  new comparation class builder to avoid long switch
sql/item_subselect.h:
  new comparation class builder to avoid long switch
sql/item_timefunc.cc:
  charset changed
sql/mysql_priv.h:
  new comparation class builder to avoid long switch
sql/mysqld.cc:
  new comparation class builder to avoid long switch
sql/sql_parse.cc:
  new comparation class builder to avoid long switch
sql/sql_string.cc:
  string printing moved to String class
sql/sql_string.h:
  string printing moved to String class
sql/sql_yacc.yy:
  birect class creation where it is possible

1 files changed, 3 insertions, 5 deletions

diff --git a/sql/item_subselect.h b/sql/item_subselect.h
index 26e165df3d3..712b3de42ad 100644
--- a/sql/item_subselect.h
+++ b/sql/item_subselect.h
@@ -27,8 +27,6 @@ class select_subselect;
 class subselect_engine;
 class Item_bool_func2;
 
-typedef Item_bool_func2* (*compare_func_creator)(Item*, Item*);
-
 /* base class for subselects */
 
 class Item_subselect :public Item_result_field
@@ -210,7 +208,7 @@ public:
   }
   trans_res select_transformer(JOIN *join);
   trans_res single_value_transformer(JOIN *join,
-				     compare_func_creator func);
+				     Comp_creator *func);
   trans_res row_value_transformer(JOIN * join);
   longlong val_int();
   double val();
@@ -229,12 +227,12 @@ public:
 class Item_allany_subselect :public Item_in_subselect
 {
 protected:
-  compare_func_creator func;
+  Comp_creator *func;
 
 public:
   bool all;
 
-  Item_allany_subselect(Item * left_expr, compare_func_creator f,
+  Item_allany_subselect(Item * left_expr, Comp_creator *f,
 		     st_select_lex *select_lex, bool all);
 
   // only ALL subquery has upper not