diff options
author | unknown <timour@askmonty.org> | 2012-05-22 15:22:55 +0300 |
---|---|---|
committer | unknown <timour@askmonty.org> | 2012-05-22 15:22:55 +0300 |
commit | 02bdc608b5599663b55a79bc9eddbd91dc06ee2a (patch) | |
tree | 75885467cf3939b837c1bbaa05eabd74367f0910 /sql/item_subselect.h | |
parent | b87ccfdfbc0a08c7cb93c41f4e36c07c6ff40b00 (diff) | |
download | mariadb-git-02bdc608b5599663b55a79bc9eddbd91dc06ee2a.tar.gz |
Fix bug lp:1002079
Analysis:
The optimizer detects an empty result through constant table optimization.
Then it calls return_zero_rows(), which in turns calls inderctly
Item_maxmin_subselect::no_rows_in_result(). The latter method set "value=0",
however "value" is pointer to Item_cache, and not just an integer value.
All of the Item_[maxmin | singlerow]_subselect::val_XXX methods does:
if (forced_const)
return value->val_real();
which of course crashes when value is a NULL pointer.
Solution:
When the optimizer discovers an empty result set, set
Item_singlerow_subselect::value to a FALSE constant Item instead of NULL.
Diffstat (limited to 'sql/item_subselect.h')
-rw-r--r-- | sql/item_subselect.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/sql/item_subselect.h b/sql/item_subselect.h index c6d1882a6b4..7f2aa857459 100644 --- a/sql/item_subselect.h +++ b/sql/item_subselect.h @@ -267,7 +267,7 @@ public: subs_type substype() { return SINGLEROW_SUBS; } void reset(); - void no_rows_in_result() { reset(); make_const(); } + void no_rows_in_result(); bool select_transformer(JOIN *join); void store(uint i, Item* item); double val_real(); |