diff options
| author | Michael Widenius <monty@mariadb.org> | 2020-07-28 19:41:05 +0300 |
|---|---|---|
| committer | Sergei Golubchik <serg@mariadb.org> | 2021-05-19 22:27:28 +0200 |
| commit | ae39f4f6d61bdd57394afa8f88285f9e34640eb7 (patch) | |
| tree | 52c6ff54e719f69cab2b9d1638ff642d12bfd9a6 /sql/item_windowfunc.cc | |
| parent | 963e5e406da7bc94eff3e8fc07f6cb625dd84d52 (diff) | |
| download | mariadb-git-ae39f4f6d61bdd57394afa8f88285f9e34640eb7.tar.gz | |
Revert MDEV-16592 "Change Item::with_sum_func to a virtual method"
Added back variable 'with_sum_func' to Item class as a bit field.
This made the code shorter, faster (removed some virtual methods,
less code to create an initialized item etc) and made many Item's 7 bytes
smaller.
The code is also easier to understand as 'with_sum_func' is threated as any
other Item variable when creating or copying items.
Diffstat (limited to 'sql/item_windowfunc.cc')
| -rw-r--r-- | sql/item_windowfunc.cc | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/sql/item_windowfunc.cc b/sql/item_windowfunc.cc index 24c2ef5a2f2..d59ad322682 100644 --- a/sql/item_windowfunc.cc +++ b/sql/item_windowfunc.cc @@ -120,6 +120,7 @@ Item_window_func::fix_fields(THD *thd, Item **ref) const_item_cache= false; with_window_func= true; + with_sum_func= false; if (fix_length_and_dec()) return TRUE; |