summaryrefslogtreecommitdiff
path: root/sql/item_xmlfunc.cc
diff options
context:
space:
mode:
authorAlexander Barkov <bar@mariadb.com>2018-05-21 13:26:16 +0400
committerVladislav Vaintroub <wlad@mariadb.com>2018-05-21 16:34:11 +0000
commit1e69d3f19616d2ac52608db4422a018930b32b0d (patch)
tree9cadb4bb0459e6d723ca284f15ec98b1d4a25b50 /sql/item_xmlfunc.cc
parent7d91d98ac12a849eebc553989b706bb820b94d79 (diff)
downloadmariadb-git-1e69d3f19616d2ac52608db4422a018930b32b0d.tar.gz
Addressing Monty's review suggestions for MDEV-11952 Oracle-style packages (partial)
- Using array_elements() instead of a constant to iterate through an array - Adding some comments - Adding new-line function comments - Using STRING_WITH_LEN instead of C_STRING_WITH_LEN
Diffstat (limited to 'sql/item_xmlfunc.cc')
-rw-r--r--sql/item_xmlfunc.cc4
1 files changed, 4 insertions, 0 deletions
diff --git a/sql/item_xmlfunc.cc b/sql/item_xmlfunc.cc
index 0b9e515a61f..63cc07fa34c 100644
--- a/sql/item_xmlfunc.cc
+++ b/sql/item_xmlfunc.cc
@@ -2632,6 +2632,10 @@ my_xpath_parse_VariableReference(MY_XPATH *xpath)
sp_variable *spv;
const Sp_rcontext_handler *rh;
LEX *lex;
+ /*
+ We call lex->find_variable() rather than thd->lex->spcont->find_variable()
+ to make sure package body variables are properly supported.
+ */
if ((lex= thd->lex) &&
(spv= lex->find_variable(&name, &rh)))
{