diff options
author | guilhem@mysql.com <> | 2005-02-23 17:38:51 +0100 |
---|---|---|
committer | guilhem@mysql.com <> | 2005-02-23 17:38:51 +0100 |
commit | 086c2a915a459bc7e2bb996c6e269304767b3004 (patch) | |
tree | ee4341e2c130045f07ecec38b6f387dd5081ce88 /sql/lock.cc | |
parent | 5e6ba9dec8f3f82745e657a2f64564ef0c5e2348 (diff) | |
download | mariadb-git-086c2a915a459bc7e2bb996c6e269304767b3004.tar.gz |
FIx for BUG#8682 "flush_block_commit test hangs on HPUX":
start_waiting_global_read_lock() should wake up all those who are waiting
for protect_against_global_read_lock to go down to 0: those registered in waiting_for_read_lock
AND those registered in global_read_lock_blocks_commit.
Diffstat (limited to 'sql/lock.cc')
-rw-r--r-- | sql/lock.cc | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/sql/lock.cc b/sql/lock.cc index 7cfa2aebe7b..8f1cd080db7 100644 --- a/sql/lock.cc +++ b/sql/lock.cc @@ -715,7 +715,7 @@ static void print_lock_error(int error) least the first step above) global_read_lock_blocks_commit count of threads which have the global read lock and block - commits (i.e. have completed the second step above) + commits (i.e. are in or have completed the second step above) waiting_for_read_lock count of threads which want to take a global read lock but cannot protect_against_global_read_lock @@ -886,7 +886,8 @@ void start_waiting_global_read_lock(THD *thd) if (unlikely(thd->global_read_lock)) DBUG_VOID_RETURN; (void) pthread_mutex_lock(&LOCK_open); - tmp= (!--protect_against_global_read_lock && waiting_for_read_lock); + tmp= (!--protect_against_global_read_lock && + (waiting_for_read_lock || global_read_lock_blocks_commit)); (void) pthread_mutex_unlock(&LOCK_open); if (tmp) pthread_cond_broadcast(&COND_refresh); |