diff options
| author | Sergei Golubchik <serg@mariadb.org> | 2015-11-13 17:53:16 +0100 |
|---|---|---|
| committer | Sergei Golubchik <serg@mariadb.org> | 2017-08-01 09:52:57 +0200 |
| commit | 60343871a73220e2a44d1cebb36e4d109c52c11c (patch) | |
| tree | 667e0a015606cfec75817628c33d681311500d7b /sql/lock.cc | |
| parent | 3d2067460eb028666f40021a371f9b2cbfd2ce9b (diff) | |
| download | mariadb-git-60343871a73220e2a44d1cebb36e4d109c52c11c.tar.gz | |
MDEV-8453 Alter table not returning engine errors
remove ~15 years old print_lock_error() function, use
handler::print_error() instead
Backport from 10.1
Diffstat (limited to 'sql/lock.cc')
| -rw-r--r-- | sql/lock.cc | 37 |
1 files changed, 3 insertions, 34 deletions
diff --git a/sql/lock.cc b/sql/lock.cc index 29afcc8f578..3354da2640b 100644 --- a/sql/lock.cc +++ b/sql/lock.cc @@ -92,7 +92,6 @@ extern HASH open_cache; static int lock_external(THD *thd, TABLE **table,uint count); static int unlock_external(THD *thd, TABLE **table,uint count); -static void print_lock_error(int error, TABLE *); /* Map the return value of thr_lock to an error from errmsg.txt */ static int thr_lock_errno_to_mysql[]= @@ -358,7 +357,7 @@ static int lock_external(THD *thd, TABLE **tables, uint count) if ((error=(*tables)->file->ha_external_lock(thd,lock_type))) { - print_lock_error(error, *tables); + (*tables)->file->print_error(error, MYF(0)); while (--i) { tables--; @@ -675,8 +674,8 @@ static int unlock_external(THD *thd, TABLE **table,uint count) (*table)->current_lock = F_UNLCK; if ((error=(*table)->file->ha_external_lock(thd, F_UNLCK))) { - error_code=error; - print_lock_error(error_code, *table); + error_code= error; + (*table)->file->print_error(error, MYF(0)); } } table++; @@ -898,36 +897,6 @@ bool lock_object_name(THD *thd, MDL_key::enum_mdl_namespace mdl_type, } -static void print_lock_error(int error, TABLE *table) -{ - int textno; - DBUG_ENTER("print_lock_error"); - - switch (error) { - case HA_ERR_LOCK_WAIT_TIMEOUT: - textno=ER_LOCK_WAIT_TIMEOUT; - break; - case HA_ERR_READ_ONLY_TRANSACTION: - textno=ER_READ_ONLY_TRANSACTION; - break; - case HA_ERR_LOCK_DEADLOCK: - textno=ER_LOCK_DEADLOCK; - break; - case HA_ERR_WRONG_COMMAND: - my_error(ER_ILLEGAL_HA, MYF(0), table->file->table_type(), - table->s->db.str, table->s->table_name.str); - DBUG_VOID_RETURN; - default: - textno=ER_CANT_LOCK; - break; - } - - my_error(textno, MYF(0), error); - - DBUG_VOID_RETURN; -} - - /**************************************************************************** Handling of global read locks |