summaryrefslogtreecommitdiff
path: root/sql/log_event.cc
diff options
context:
space:
mode:
authorunknown <guilhem@mysql.com>2005-03-02 16:37:54 +0100
committerunknown <guilhem@mysql.com>2005-03-02 16:37:54 +0100
commit463ee77daf5347e1ddf7153c4570dffee314041f (patch)
tree03a57dc25e48ac118dfc1527d3f1c48e131f78a3 /sql/log_event.cc
parent8fdc684b0b2baf7027ffaf38fa429336532e71c1 (diff)
downloadmariadb-git-463ee77daf5347e1ddf7153c4570dffee314041f.tar.gz
First part of fix for BUG#7998 "Replication should be more clever about when to replicate RELEASE_LOCK()"
(next part is updating test results) sql/item_func.cc: no need for binlogging DO RELEASE_LOCK() anymore. Make GET_LOCK() do nothing in slave thread. sql/log_event.cc: comment fixes sql/mysqld.cc: warning removed sql/slave.cc: fix after merge
Diffstat (limited to 'sql/log_event.cc')
-rw-r--r--sql/log_event.cc10
1 files changed, 5 insertions, 5 deletions
diff --git a/sql/log_event.cc b/sql/log_event.cc
index 7f92159208b..889550465bc 100644
--- a/sql/log_event.cc
+++ b/sql/log_event.cc
@@ -1616,9 +1616,9 @@ end:
probably, so data_buf will be freed, so the thd->... listed above will be
pointers to freed memory.
So we must set them to 0, so that those bad pointers values are not later
- used. Note that "cleanup" queries (automatic DO RELEASE_LOCK() and DROP
- TEMPORARY TABLE don't suffer from these assignments to 0 as DROP TEMPORARY
- TABLE uses the db.table syntax).
+ used. Note that "cleanup" queries like automatic DROP TEMPORARY TABLE
+ don't suffer from these assignments to 0 as DROP TEMPORARY
+ TABLE uses the db.table syntax.
*/
thd->db= thd->catalog= 0; // prevent db from being freed
thd->query= 0; // just to be sure
@@ -3663,8 +3663,8 @@ void Stop_log_event::print(FILE* file, bool short_form, LAST_EVENT_INFO* last_ev
The master stopped.
We used to clean up all temporary tables but this is useless as, as the
- master has shut down properly, it has written all DROP TEMPORARY TABLE and DO
- RELEASE_LOCK (prepared statements' deletion is TODO).
+ master has shut down properly, it has written all DROP TEMPORARY TABLE
+ (prepared statements' deletion is TODO only when we binlog prep stmts).
We used to clean up slave_load_tmpdir, but this is useless as it has been
cleared at the end of LOAD DATA INFILE.
So we have nothing to do here.