diff options
| author | dlenev@mysql.com <> | 2003-08-20 03:38:31 +0400 |
|---|---|---|
| committer | dlenev@mysql.com <> | 2003-08-20 03:38:31 +0400 |
| commit | bb96092202781f33cefe63c7f1290bfad39463e8 (patch) | |
| tree | 0a3c8f9aa8f5e896442645fcead2090909683c4f /sql/repl_failsafe.cc | |
| parent | 6e32e19047a745b465f7b169966a7112e2d12047 (diff) | |
| download | mariadb-git-bb96092202781f33cefe63c7f1290bfad39463e8.tar.gz | |
Fix for BUG#1086. Now we don't preserve event's log_pos through
log-slave-updates since this causes unexpected values in
Exec_master_log_pos in A->B->C replication setup, synchronization
problems in master_pos_wait()...
Still this brokes some functionality in sql/repl_failsafe.cc
(but this file is not used now)
Diffstat (limited to 'sql/repl_failsafe.cc')
| -rw-r--r-- | sql/repl_failsafe.cc | 15 |
1 files changed, 15 insertions, 0 deletions
diff --git a/sql/repl_failsafe.cc b/sql/repl_failsafe.cc index 0a5f90617d1..dc3f3c87dde 100644 --- a/sql/repl_failsafe.cc +++ b/sql/repl_failsafe.cc @@ -249,6 +249,18 @@ static int find_target_pos(LEX_MASTER_INFO *mi, IO_CACHE *log, char *errmsg) /* Impossible */ } +/* + Before 4.0.15 we had a member of THD called log_pos, it was meant for + failsafe replication code in repl_failsafe.cc which is disabled until + it is reworked. Event's log_pos used to be preserved through + log-slave-updates to make code in repl_failsafe.cc work (this + function, SHOW NEW MASTER); but on the other side it caused unexpected + values in Exec_master_log_pos in A->B->C replication setup, + synchronization problems in master_pos_wait(), ... So we + (Dmitri & Guilhem) removed it. + + So for now this function is broken. +*/ int translate_master(THD* thd, LEX_MASTER_INFO* mi, char* errmsg) { @@ -414,6 +426,9 @@ static Slave_log_event* find_slave_event(IO_CACHE* log, return (Slave_log_event*)ev; } +/* + This function is broken now. See comment for translate_master(). + */ int show_new_master(THD* thd) { |