diff options
author | Sergey Vojtovich <svoj@mariadb.org> | 2019-03-21 00:42:48 +0400 |
---|---|---|
committer | Sergey Vojtovich <svoj@mariadb.org> | 2019-05-03 16:46:11 +0400 |
commit | 894df7edb67b888c41eae5ffbe654ceba97c6b8f (patch) | |
tree | f5d1e9d5fb1c33e0027dd94260361429395c23e4 /sql/set_var.h | |
parent | 53671a1fff8d4aa0978be2fb916f8e053c09424a (diff) | |
download | mariadb-git-894df7edb67b888c41eae5ffbe654ceba97c6b8f.tar.gz |
Adieu find_sys_var_ex()
Only take LOCK_plugin for plugin system variables.
Reverted optimisation that was originally done for session tracker: it
makes much less sense now. Specifically only if connections would want to
track plugin session variables changes and these changes would actually
happen frequently. If this ever becomes an issue, there're much better
ways to optimise this workload.
Part of MDEV-14984 - regression in connect performance
Diffstat (limited to 'sql/set_var.h')
-rw-r--r-- | sql/set_var.h | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/sql/set_var.h b/sql/set_var.h index 6097b28e76f..6e673cffefb 100644 --- a/sql/set_var.h +++ b/sql/set_var.h @@ -398,7 +398,8 @@ extern SHOW_COMP_OPTION have_openssl; SHOW_VAR* enumerate_sys_vars(THD *thd, bool sorted, enum enum_var_type type); int fill_sysvars(THD *thd, TABLE_LIST *tables, COND *cond); -sys_var *find_sys_var(THD *thd, const char *str, size_t length=0); +sys_var *find_sys_var(THD *thd, const char *str, size_t length= 0, + bool throw_error= false); int sql_set_variables(THD *thd, List<set_var_base> *var_list, bool free); #define SYSVAR_AUTOSIZE(VAR,VAL) \ |