summaryrefslogtreecommitdiff
path: root/sql/set_var.h
diff options
context:
space:
mode:
authorAlexey Botchkov <holyfoot@mysql.com>2010-09-02 23:37:04 +0500
committerAlexey Botchkov <holyfoot@mysql.com>2010-09-02 23:37:04 +0500
commitc6024dfc4e09d5eed076230a8645a8f4dae0d2f8 (patch)
tree118ad3b6cdad8674425315bda73619e5783bc743 /sql/set_var.h
parent7e8d74505e2334db76a20360168e650149c99cc5 (diff)
downloadmariadb-git-c6024dfc4e09d5eed076230a8645a8f4dae0d2f8.tar.gz
Bug#53251 mysql_library_init fails on second execution with embedded library
thread-specific variables weren't set when we load error message files. per-file comments: libmysqld/lib_sql.cc Bug#53251 mysql_library_init fails on second execution with embedded library we need to call my_thread_init() once more. Normally it's called at the my_init() stage but that doesn't happen on the second my_init() call. sql/derror.cc Bug#53251 mysql_library_init fails on second execution with embedded library use default errors for the embedded server. sql/mysqld.cc Bug#53251 mysql_library_init fails on second execution with embedded library unregister server errors in clean_up(). Without it the error list contains that on the second mysql_server_init() which is not good. sql/set_var.cc Bug#53251 mysql_library_init fails on second execution with embedded library sys_var::cleanup() call instead of the destructor sql/set_var.h Bug#53251 mysql_library_init fails on second execution with embedded library sys_var::cleanup() introduced instead of the destructor sql/sys_vars.h Bug#53251 mysql_library_init fails on second execution with embedded library Sys_var_charptr::cleanup() implemented
Diffstat (limited to 'sql/set_var.h')
-rw-r--r--sql/set_var.h5
1 files changed, 2 insertions, 3 deletions
diff --git a/sql/set_var.h b/sql/set_var.h
index 5f1f889c4ce..ece3b80edb4 100644
--- a/sql/set_var.h
+++ b/sql/set_var.h
@@ -92,10 +92,9 @@ public:
on_check_function on_check_func, on_update_function on_update_func,
uint deprecated_version, const char *substitute, int parse_flag);
/**
- The instance should only be destroyed on shutdown, as it doesn't unlink
- itself from the chain.
+ All the cleanup procedures should be performed here
*/
- virtual ~sys_var() {}
+ virtual void cleanup() {}
/**
downcast for sys_var_pluginvar. Returns this if it's an instance
of sys_var_pluginvar, and 0 otherwise.