diff options
| author | Alexander Barkov <bar@mariadb.com> | 2018-05-21 13:26:16 +0400 |
|---|---|---|
| committer | Vladislav Vaintroub <wlad@mariadb.com> | 2018-05-21 16:34:11 +0000 |
| commit | 1e69d3f19616d2ac52608db4422a018930b32b0d (patch) | |
| tree | 9cadb4bb0459e6d723ca284f15ec98b1d4a25b50 /sql/sp.h | |
| parent | 7d91d98ac12a849eebc553989b706bb820b94d79 (diff) | |
| download | mariadb-git-1e69d3f19616d2ac52608db4422a018930b32b0d.tar.gz | |
Addressing Monty's review suggestions for MDEV-11952 Oracle-style packages (partial)
- Using array_elements() instead of a constant to iterate through an array
- Adding some comments
- Adding new-line function comments
- Using STRING_WITH_LEN instead of C_STRING_WITH_LEN
Diffstat (limited to 'sql/sp.h')
| -rw-r--r-- | sql/sp.h | 8 |
1 files changed, 4 insertions, 4 deletions
@@ -371,12 +371,12 @@ public: stored_procedure_type type() const { return TYPE_ENUM_PACKAGE; } LEX_CSTRING type_lex_cstring() const { - static LEX_CSTRING m_type_str= {C_STRING_WITH_LEN("PACKAGE")}; + static LEX_CSTRING m_type_str= {STRING_WITH_LEN("PACKAGE")}; return m_type_str; } LEX_CSTRING empty_body_lex_cstring(sql_mode_t mode) const { - static LEX_CSTRING m_empty_body= {C_STRING_WITH_LEN("BEGIN END")}; + static LEX_CSTRING m_empty_body= {STRING_WITH_LEN("BEGIN END")}; return m_empty_body; } const char *show_create_routine_col1_caption() const @@ -404,12 +404,12 @@ public: stored_procedure_type type() const { return TYPE_ENUM_PACKAGE_BODY; } LEX_CSTRING type_lex_cstring() const { - static LEX_CSTRING m_type_str= {C_STRING_WITH_LEN("PACKAGE BODY")}; + static LEX_CSTRING m_type_str= {STRING_WITH_LEN("PACKAGE BODY")}; return m_type_str; } LEX_CSTRING empty_body_lex_cstring(sql_mode_t mode) const { - static LEX_CSTRING m_empty_body= {C_STRING_WITH_LEN("BEGIN END")}; + static LEX_CSTRING m_empty_body= {STRING_WITH_LEN("BEGIN END")}; return m_empty_body; } const char *show_create_routine_col1_caption() const |