diff options
| author | unknown <pem@mysql.com> | 2005-11-18 16:30:27 +0100 |
|---|---|---|
| committer | unknown <pem@mysql.com> | 2005-11-18 16:30:27 +0100 |
| commit | 6726a6b8b9cc6059f8080846185114e42f248556 (patch) | |
| tree | 511c72f417c8aa02f30a0a354d4641217c9c1dca /sql/sp_pcontext.h | |
| parent | 91ab707678870966b9410cd3bdd783eb2a7c19e4 (diff) | |
| download | mariadb-git-6726a6b8b9cc6059f8080846185114e42f248556.tar.gz | |
Post-review fixes, mainly fixing all print() methods for sp_instr* classes.
Also added mysql-test files:
include/is_debug_build.inc
r/is_debug_build.require
r/sp-code.result
t/sp-code.test
sql/sp_head.cc:
Review fixes:
- Some minor editorial changes
- Fixed all print() methods for instructions:
- reserve() enough space
- check return value from reserve()
- use qs_append, with length arg, whenever possible
sql/sp_pcontext.cc:
Review fixes.
Also fixed bug in find_cursor().
sql/sp_pcontext.h:
Changed parameter names (review fix).
sql/sql_parse.cc:
Moved comment. (Review fix)
mysql-test/include/is_debug_build.inc:
New BitKeeper file ``mysql-test/include/is_debug_build.inc''
mysql-test/r/is_debug_build.require:
New BitKeeper file ``mysql-test/r/is_debug_build.require''
mysql-test/r/sp-code.result:
New BitKeeper file ``mysql-test/r/sp-code.result''
mysql-test/t/sp-code.test:
New BitKeeper file ``mysql-test/t/sp-code.test''
Diffstat (limited to 'sql/sp_pcontext.h')
| -rw-r--r-- | sql/sp_pcontext.h | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/sql/sp_pcontext.h b/sql/sp_pcontext.h index 77e749fe3ad..b8dd1742f7e 100644 --- a/sql/sp_pcontext.h +++ b/sql/sp_pcontext.h @@ -170,9 +170,9 @@ class sp_pcontext : public Sql_alloc sp_pvar_t * find_pvar(LEX_STRING *name, my_bool scoped=0); - // Find by index + // Find by offset sp_pvar_t * - find_pvar(uint i); + find_pvar(uint offset); // // Labels @@ -252,9 +252,9 @@ class sp_pcontext : public Sql_alloc my_bool find_cursor(LEX_STRING *name, uint *poff, my_bool scoped=0); - /* Find by index (for debugging only) */ + /* Find by offset (for debugging only) */ my_bool - find_cursor(uint i, LEX_STRING *n); + find_cursor(uint offset, LEX_STRING *n); inline uint max_cursors() |