summaryrefslogtreecommitdiff
path: root/sql/sql_admin.cc
diff options
context:
space:
mode:
authorNisha Gopalakrishnan <nisha.gopalakrishnan@oracle.com>2018-02-26 14:37:39 +0530
committerNisha Gopalakrishnan <nisha.gopalakrishnan@oracle.com>2018-02-26 14:37:39 +0530
commitc0b4d74b52e7eec9b13af732193f7f8d7abe05de (patch)
treef9a56f685812262c4a9e3a7c8972207addefd277 /sql/sql_admin.cc
parent873f8c25b6de24d267cbdedc70de40dc4b5b83aa (diff)
downloadmariadb-git-c0b4d74b52e7eec9b13af732193f7f8d7abe05de.tar.gz
BUG#27216817: INNODB: FAILING ASSERTION:mysql-5.5.60
PREBUILT->TABLE->N_MYSQL_HANDLES_OPENED == 1 ANALYSIS: ========= Adding unique index to a InnoDB table which is locked as mutliple instances may trigger an InnoDB assert. When we add a primary key or an unique index, we need to drop the original table and rebuild all indexes. InnoDB expects that only the instance of the table that is being rebuilt, is open during the process. In the current scenario we have opened multiple instances of the table. This triggers an assert during table rebuild. 'Locked_tables_list' encapsulates a list of all instances of tables locked by LOCK TABLES statement. FIX: === We are now temporarily closing all the instances of the table except the one which is being altered and later reopen them via Locked_tables_list::reopen_tables().
Diffstat (limited to 'sql/sql_admin.cc')
-rw-r--r--sql/sql_admin.cc4
1 files changed, 2 insertions, 2 deletions
diff --git a/sql/sql_admin.cc b/sql/sql_admin.cc
index efdb67d01c4..bfe4edb67c4 100644
--- a/sql/sql_admin.cc
+++ b/sql/sql_admin.cc
@@ -1,4 +1,4 @@
-/* Copyright (c) 2010, 2015, Oracle and/or its affiliates. All rights
+/* Copyright (c) 2010, 2018, Oracle and/or its affiliates. All rights
reserved.
This program is free software; you can redistribute it and/or modify
@@ -168,7 +168,7 @@ static int prepare_for_repair(THD *thd, TABLE_LIST *table_list,
*/
if (wait_while_table_is_used(thd, table, HA_EXTRA_FORCE_REOPEN))
goto end;
- close_all_tables_for_name(thd, table_list->table->s, FALSE);
+ close_all_tables_for_name(thd, table_list->table->s, FALSE, NULL);
table_list->table= 0;
}
/*