diff options
| author | Alexander Barkov <bar@mariadb.com> | 2018-06-05 10:25:39 +0400 |
|---|---|---|
| committer | Alexander Barkov <bar@mariadb.com> | 2018-06-05 10:25:39 +0400 |
| commit | 106f0b5798a2b5d13b7d67c3cc678fc0cc2184c2 (patch) | |
| tree | 051be6f9936bb23d3db3e3591016e09de159f19c /sql/sql_analyse.cc | |
| parent | b50685af82508ca1cc83e1743dff527770e6e64b (diff) | |
| download | mariadb-git-106f0b5798a2b5d13b7d67c3cc678fc0cc2184c2.tar.gz | |
MDEV-16385 ROW SP variable is allowed in unexpected context
The problem described in the bug report happened because the code
did not test check_cols(1) after fix_fields() in a few places.
Additionally, fix_fields() could be called multiple times for SP variables,
because they are all fixed at a early stage in append_for_log().
Solution:
1. Adding a few helper methods
- fix_fields_if_needed()
- fix_fields_if_needed_for_scalar()
- fix_fields_if_needed_for_bool()
- fix_fields_if_needed_for_order_by()
and using it in many cases instead of fix_fields() where
the "fixed" status is not definitely known to be "false".
2. Adding DBUG_ASSERT(!fixed) into Item_splocal*::fix_fields()
to catch double execution.
3. Adding tests.
As a good side effect, the patch removes a lot of duplicate code (~60 lines):
if (!item->fixed &&
item->fix_fields(..) &&
item->check_cols(1))
return true;
Diffstat (limited to 'sql/sql_analyse.cc')
| -rw-r--r-- | sql/sql_analyse.cc | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/sql/sql_analyse.cc b/sql/sql_analyse.cc index 351ddb452d8..6626a054052 100644 --- a/sql/sql_analyse.cc +++ b/sql/sql_analyse.cc @@ -88,7 +88,7 @@ proc_analyse_init(THD *thd, ORDER *param, select_result *result, else if (param->next) { // first parameter - if (!(*param->item)->fixed && (*param->item)->fix_fields(thd, param->item)) + if ((*param->item)->fix_fields_if_needed(thd, param->item)) { DBUG_PRINT("info", ("fix_fields() for the first parameter failed")); goto err; @@ -107,7 +107,7 @@ proc_analyse_init(THD *thd, ORDER *param, select_result *result, goto err; } // second parameter - if (!(*param->item)->fixed && (*param->item)->fix_fields(thd, param->item)) + if ((*param->item)->fix_fields_if_needed(thd, param->item)) { DBUG_PRINT("info", ("fix_fields() for the second parameter failed")); goto err; |