diff options
| author | Varun Gupta <varunraiko1803@gmail.com> | 2017-07-12 19:46:44 +0530 |
|---|---|---|
| committer | Varun Gupta <varunraiko1803@gmail.com> | 2017-07-12 19:46:44 +0530 |
| commit | 9b4d281ecd01b0d1d4a55dfaff5f27720037cb77 (patch) | |
| tree | 4b8053b3d2f817a33b8dc92204292ac93ab6ecb3 /sql/sql_analyze_stmt.cc | |
| parent | 52a5bfa078fbd3ef08119c1c1ab197132d221c8f (diff) | |
| download | mariadb-git-9b4d281ecd01b0d1d4a55dfaff5f27720037cb77.tar.gz | |
MDEV-13826: Floating point exception in Filesort_tracker::print_json_members(Json_writer*)
Whenever Filesort_tracker has r_loops=0, r_ouptut_rows would be 0, so we should add the value zero
to the member "r_output_rows" explicitly
Diffstat (limited to 'sql/sql_analyze_stmt.cc')
| -rw-r--r-- | sql/sql_analyze_stmt.cc | 21 |
1 files changed, 16 insertions, 5 deletions
diff --git a/sql/sql_analyze_stmt.cc b/sql/sql_analyze_stmt.cc index cc6e0f89f75..ac3797aae60 100644 --- a/sql/sql_analyze_stmt.cc +++ b/sql/sql_analyze_stmt.cc @@ -26,7 +26,11 @@ void Filesort_tracker::print_json_members(Json_writer *writer) { const char *varied_str= "(varied across executions)"; - writer->add_member("r_loops").add_ll(get_r_loops()); + + if (!get_r_loops()) + writer->add_member("r_loops").add_null(); + else + writer->add_member("r_loops").add_ll(get_r_loops()); if (get_r_loops() && time_tracker.timed) { @@ -36,22 +40,29 @@ void Filesort_tracker::print_json_members(Json_writer *writer) if (r_limit != HA_POS_ERROR) { writer->add_member("r_limit"); - if (r_limit == 0) + if (!get_r_loops()) + writer->add_null(); + else if (r_limit == 0) writer->add_str(varied_str); else writer->add_ll((longlong) rint(r_limit/get_r_loops())); } writer->add_member("r_used_priority_queue"); - if (r_used_pq == get_r_loops()) + if (!get_r_loops()) + writer->add_null(); + else if (r_used_pq == get_r_loops()) writer->add_bool(true); else if (r_used_pq == 0) writer->add_bool(false); else writer->add_str(varied_str); - writer->add_member("r_output_rows").add_ll((longlong) rint(r_output_rows / - get_r_loops())); + if (!get_r_loops()) + writer->add_member("r_output_rows").add_null(); + else + writer->add_member("r_output_rows").add_ll((longlong) rint(r_output_rows / + get_r_loops())); if (sort_passes) { |