diff options
author | unknown <guilhem@mysql.com> | 2006-06-20 10:40:36 +0200 |
---|---|---|
committer | unknown <guilhem@mysql.com> | 2006-06-20 10:40:36 +0200 |
commit | 339deb0c07eab5f563a4a72b08bf0162953b4f62 (patch) | |
tree | ec776da84546d93b755251ba83332cf923afed36 /sql/sql_class.h | |
parent | 198b8744ea7e105ecaf635a922a432050fd2d15b (diff) | |
download | mariadb-git-339deb0c07eab5f563a4a72b08bf0162953b4f62.tar.gz |
Fix for BUG#20522 "RBR: CREATE TEMPORARY TABLE SELECT writes to binlog
though unneeded". It's indeed unneeded, as slave is only interested in
permanent tables, and permanent tables don't depend on temporary tables
when in row-based binlogging mode. And other CREATE TEMPORARY TABLE
(referring no table or with LIKE) already don't write the CREATE to
binlog in row-based mode.
mysql-test/r/rpl_row_create_table.result:
result update (note that no lines appear in SHOW BINLOG EVENTS further below, which is how we
see the bug is fixed)
mysql-test/t/rpl_row_create_table.test:
testing if a CREATE TEMPORARY TABLE SELECT goes to binlog (it should not)
when in row-based binlogging mode. A few lines after, there is a SHOW
BINLOG EVENTS; before the bugfix it showed the CREATE TEMPORARY TABLE.
sql/sql_class.h:
a method to access select_create::create_info from outside of select_create
("read-only" access). Making get_thd() "read-only" too.
sql/sql_insert.cc:
The function (hook) which writes CREATE TABLE to binlog when in row-based
binlogging mode, for CREATE TABLE SELECT, now does nothing if the table
is temporary (as in row-based mode, temp tables are not replicated).
This is consistent with CREATE TEMPORARY TABLE LIKE and
CREATE TEMPORARY TABLE, which don't write any CREATE to binlog in row-based
mode.
Diffstat (limited to 'sql/sql_class.h')
-rw-r--r-- | sql/sql_class.h | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/sql/sql_class.h b/sql/sql_class.h index 723dad715bd..b5328d4c56b 100644 --- a/sql/sql_class.h +++ b/sql/sql_class.h @@ -1610,7 +1610,8 @@ public: virtual bool can_rollback_data() { return 1; } // Needed for access from local class MY_HOOKS in prepare(), since thd is proteted. - THD *get_thd(void) { return thd; } + const THD *get_thd(void) { return thd; } + const HA_CREATE_INFO *get_create_info() { return create_info; }; }; #include <myisam.h> |