summaryrefslogtreecommitdiff
path: root/sql/sql_insert.cc
diff options
context:
space:
mode:
authorSergey Petrunya <psergey@askmonty.org>2013-10-16 12:13:51 +0400
committerSergey Petrunya <psergey@askmonty.org>2013-10-16 12:13:51 +0400
commit4bed7aa858e7946471fb37ce30f3273ec28867ce (patch)
tree88ed0acf75fcb99839ea364e418d2bc19c0705b8 /sql/sql_insert.cc
parent207f0082202fd822fe1d0d3083c7fff5de6d8847 (diff)
downloadmariadb-git-4bed7aa858e7946471fb37ce30f3273ec28867ce.tar.gz
MDEV-3798: [SHOW] EXPLAIN UPDATE/DELETE, Memory leak in binlog.binlog_base64_flag:
- It turns out, there are statements that will call lex_start(thd->lex) after parsing has been finished. lex_start() will set lex->explain=NULL, which will lose the pointer to already allocated Explain_plan object. - To get rid of this, switch to lazy creation of lex->explain. Now, it is created only when we get a part ot query plan.
Diffstat (limited to 'sql/sql_insert.cc')
-rw-r--r--sql/sql_insert.cc1
1 files changed, 1 insertions, 0 deletions
diff --git a/sql/sql_insert.cc b/sql/sql_insert.cc
index 24b43442e2a..b21650dc559 100644
--- a/sql/sql_insert.cc
+++ b/sql/sql_insert.cc
@@ -719,6 +719,7 @@ bool mysql_insert(THD *thd,TABLE_LIST *table_list,
Item *unused_conds= 0;
DBUG_ENTER("mysql_insert");
+ create_explain_query(thd->lex, thd->mem_root);
/*
Upgrade lock type if the requested lock is incompatible with
the current connection mode or table operation.