diff options
| author | Sergei Golubchik <serg@mariadb.org> | 2017-01-16 18:23:02 +0100 |
|---|---|---|
| committer | Sergei Golubchik <serg@mariadb.org> | 2017-01-17 20:16:09 +0100 |
| commit | ef8003eb9a23007ac5d606530dcdcc3ea2f0c039 (patch) | |
| tree | b374ac22e4a21b295c378fba316c5b3fa78126d6 /sql/sql_insert.h | |
| parent | e79e840607adff6f2e55d4c889ae055d07bdabf5 (diff) | |
| download | mariadb-git-ef8003eb9a23007ac5d606530dcdcc3ea2f0c039.tar.gz | |
MDEV-11698 Old Bug possibly not fixed; BEFORE INSERT Trigger on NOT NULL
check_that_all_fields_are_given_values() relied on write_set,
but was run too early, before triggers updated write_set.
also, when triggers are present, fields might get values conditionally,
so we need to check that all fields are given values for every row.
Diffstat (limited to 'sql/sql_insert.h')
| -rw-r--r-- | sql/sql_insert.h | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/sql/sql_insert.h b/sql/sql_insert.h index cbfc1ea9dcd..aea0dac6b0d 100644 --- a/sql/sql_insert.h +++ b/sql/sql_insert.h @@ -27,8 +27,7 @@ bool mysql_prepare_insert(THD *thd, TABLE_LIST *table_list, TABLE *table, List<Item> &fields, List_item *values, List<Item> &update_fields, List<Item> &update_values, enum_duplicates duplic, - COND **where, bool select_insert, - bool check_fields, bool abort_on_warning); + COND **where, bool select_insert); bool mysql_insert(THD *thd,TABLE_LIST *table,List<Item> &fields, List<List_item> &values, List<Item> &update_fields, List<Item> &update_values, enum_duplicates flag, |