diff options
author | Sergey Petrunya <psergey@askmonty.org> | 2011-03-22 19:42:36 +0300 |
---|---|---|
committer | Sergey Petrunya <psergey@askmonty.org> | 2011-03-22 19:42:36 +0300 |
commit | f064087ed0eba378ef83270562ec3f9438d88859 (patch) | |
tree | 3b1d2ca79e1e71fc5a6c55cfcb070def4994c874 /sql/sql_join_cache.cc | |
parent | 739e6c99a27fbc957546941e5303653585706133 (diff) | |
download | mariadb-git-f064087ed0eba378ef83270562ec3f9438d88859.tar.gz |
MWL#90: Address review feedback part #9:
- among everything else, switch to using first/next_linear_tab() in make_outerjoin_info().
Diffstat (limited to 'sql/sql_join_cache.cc')
-rw-r--r-- | sql/sql_join_cache.cc | 8 |
1 files changed, 7 insertions, 1 deletions
diff --git a/sql/sql_join_cache.cc b/sql/sql_join_cache.cc index 2250e38fc72..87c1fb9f2ec 100644 --- a/sql/sql_join_cache.cc +++ b/sql/sql_join_cache.cc @@ -2169,7 +2169,13 @@ enum_nested_loop_state JOIN_CACHE::join_matching_records(bool skip_last) /* Prepare to retrieve all records of the joined table */ if ((error= join_tab_scan->open())) - goto finish; /* psergey-note: if this returns error, we will assert in net_send_statement() */ + { + /* + TODO: if we get here, we will assert in net_send_statement(). Add test + coverage and fix. + */ + goto finish; + } while (!(error= join_tab_scan->next())) { |