diff options
| author | Alexander Barkov <bar@mariadb.com> | 2018-05-21 13:26:16 +0400 |
|---|---|---|
| committer | Vladislav Vaintroub <wlad@mariadb.com> | 2018-05-21 16:34:11 +0000 |
| commit | 1e69d3f19616d2ac52608db4422a018930b32b0d (patch) | |
| tree | 9cadb4bb0459e6d723ca284f15ec98b1d4a25b50 /sql/sql_lex.h | |
| parent | 7d91d98ac12a849eebc553989b706bb820b94d79 (diff) | |
| download | mariadb-git-1e69d3f19616d2ac52608db4422a018930b32b0d.tar.gz | |
Addressing Monty's review suggestions for MDEV-11952 Oracle-style packages (partial)
- Using array_elements() instead of a constant to iterate through an array
- Adding some comments
- Adding new-line function comments
- Using STRING_WITH_LEN instead of C_STRING_WITH_LEN
Diffstat (limited to 'sql/sql_lex.h')
| -rw-r--r-- | sql/sql_lex.h | 14 |
1 files changed, 7 insertions, 7 deletions
diff --git a/sql/sql_lex.h b/sql/sql_lex.h index 2517fb6b544..bfb201185b1 100644 --- a/sql/sql_lex.h +++ b/sql/sql_lex.h @@ -319,13 +319,13 @@ enum enum_sp_aggregate_type GROUP_AGGREGATE }; -const LEX_STRING sp_data_access_name[]= +const LEX_CSTRING sp_data_access_name[]= { - { C_STRING_WITH_LEN("") }, - { C_STRING_WITH_LEN("CONTAINS SQL") }, - { C_STRING_WITH_LEN("NO SQL") }, - { C_STRING_WITH_LEN("READS SQL DATA") }, - { C_STRING_WITH_LEN("MODIFIES SQL DATA") } + { STRING_WITH_LEN("") }, + { STRING_WITH_LEN("CONTAINS SQL") }, + { STRING_WITH_LEN("NO SQL") }, + { STRING_WITH_LEN("READS SQL DATA") }, + { STRING_WITH_LEN("MODIFIES SQL DATA") } }; #define DERIVED_SUBQUERY 1 @@ -3685,7 +3685,7 @@ public: Item *value); sp_variable *sp_add_for_loop_upper_bound(THD *thd, Item *value) { - LEX_CSTRING name= { C_STRING_WITH_LEN("[upper_bound]") }; + LEX_CSTRING name= { STRING_WITH_LEN("[upper_bound]") }; return sp_add_for_loop_variable(thd, &name, value); } bool sp_for_loop_intrange_declarations(THD *thd, Lex_for_loop_st *loop, |