diff options
| author | Julius Goryavsky <sysprg@gmail.com> | 2019-02-15 10:58:59 +0100 |
|---|---|---|
| committer | Jan Lindström <jan.lindstrom@mariadb.com> | 2019-02-25 11:19:07 +0200 |
| commit | 243f829c1c772c1b8e9e0717fbf5839e84244559 (patch) | |
| tree | 43934a4eeeb002ee85607a7d26c492e4ee8b58cd /sql/sql_plugin_services.ic | |
| parent | 28cb041754f9f77e915ecd9c5276e02a1ab4cec5 (diff) | |
| download | mariadb-git-243f829c1c772c1b8e9e0717fbf5839e84244559.tar.gz | |
MDEV-9519: Data corruption will happen on the Galera cluster size change
If we have a 2+ node cluster which is replicating from an async master
and the binlog_format is set to STATEMENT and multi-row inserts are executed
on a table with an auto_increment column such that values are automatically
generated by MySQL, then the server node generates wrong auto_increment
values, which are different from what was generated on the async master.
In the title of the MDEV-9519 it was proposed to ban start slave on a Galera
if master binlog_format = statement and wsrep_auto_increment_control = 1,
but the problem can be solved without such a restriction.
The causes and fixes:
1. We need to improve processing of changing the auto-increment values
after changing the cluster size.
2. If wsrep auto_increment_control switched on during operation of
the node, then we should immediately update the auto_increment_increment
and auto_increment_offset global variables, without waiting of the next
invocation of the wsrep_view_handler_cb() callback. In the current version
these variables retain its initial values if wsrep_auto_increment_control
is switched on during operation of the node, which leads to inconsistent
results on the different nodes in some scenarios.
3. If wsrep auto_increment_control switched off during operation of the node,
then we must return the original values of the auto_increment_increment and
auto_increment_offset global variables, as the user has set. To make this
possible, we need to add a "shadow copies" of these variables (which stores
the latest values set by the user).
https://jira.mariadb.org/browse/MDEV-9519
Diffstat (limited to 'sql/sql_plugin_services.ic')
| -rw-r--r-- | sql/sql_plugin_services.ic | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/sql/sql_plugin_services.ic b/sql/sql_plugin_services.ic index 95301a5fbe8..427d8937c57 100644 --- a/sql/sql_plugin_services.ic +++ b/sql/sql_plugin_services.ic @@ -177,6 +177,7 @@ static struct wsrep_service_st wsrep_handler = { wsrep_thd_ignore_table, wsrep_thd_trx_seqno, wsrep_thd_ws_handle, + wsrep_thd_auto_increment_variables, wsrep_trx_is_aborting, wsrep_trx_order_before, wsrep_unlock_rollback, |