diff options
| author | Alfranio Correia <alfranio.correia@oracle.com> | 2011-11-02 15:28:18 +0000 |
|---|---|---|
| committer | Alfranio Correia <alfranio.correia@oracle.com> | 2011-11-02 15:28:18 +0000 |
| commit | d1ba9b328fbc90a5201c39ea597a236a93462d4e (patch) | |
| tree | 5f5a1797b1f22bd0409be8cb15fbf64b284d1c5b /sql/sql_repl.cc | |
| parent | c45f539bece6301b7154c9ea855172d2769143e0 (diff) | |
| download | mariadb-git-d1ba9b328fbc90a5201c39ea597a236a93462d4e.tar.gz | |
BUG#13337202 - REPLICATION PERFORMANCE DROP DUE TO "THE BINLOG MAY BE CORRUPTED" FLOOD
In patch mysql-5.5:revno:3097.92.133, we made the gcc 4.6.1 compiler
to stop complaining about the fact that binlog_can_be_corrupted was
defined but not used. The fix consisted in checking the variable
and printing a warning message.
However, the fix caused a regression as a message was being printed
out when there was no corrupted binary log causing performance
problems and triggering users' suspicions when there was no need.
In BUG#13337202, we do not print any message and use the variable
in an "if" with an empty body to keep the compiler happy.
Diffstat (limited to 'sql/sql_repl.cc')
| -rw-r--r-- | sql/sql_repl.cc | 10 |
1 files changed, 9 insertions, 1 deletions
diff --git a/sql/sql_repl.cc b/sql/sql_repl.cc index 80fef42434c..5d6d8bb13e3 100644 --- a/sql/sql_repl.cc +++ b/sql/sql_repl.cc @@ -731,7 +731,15 @@ impossible position"; /Alfranio */ if (binlog_can_be_corrupted) - sql_print_information("The binlog may be corrupted."); + { + /* + Don't try to print out warning messages because this generates + erroneous messages in the error log and causes performance + problems. + + /Alfranio + */ + } pos = my_b_tell(&log); if (RUN_HOOK(binlog_transmit, before_send_event, |