summaryrefslogtreecommitdiff
path: root/sql/sql_select.cc
diff options
context:
space:
mode:
authorunknown <monty@mysql.com>2003-12-18 14:40:19 +0200
committerunknown <monty@mysql.com>2003-12-18 14:40:19 +0200
commit15484ba20c887c7970b7f164c32aade2967c4b66 (patch)
tree6b1f00f092b3ba754b2428500a6a935f8c1d46b1 /sql/sql_select.cc
parent6b1e06e62080e684f61ef6d278d91a2f4c8c4309 (diff)
downloadmariadb-git-15484ba20c887c7970b7f164c32aade2967c4b66.tar.gz
Simple cleanups
mysql-test/t/auto_increment.test: Fixed wrong comment sql/opt_range.cc: Removed not used variable sql/sql_select.cc: Removed indentation level (This will also make merges into 4.1 easier)
Diffstat (limited to 'sql/sql_select.cc')
-rw-r--r--sql/sql_select.cc52
1 files changed, 24 insertions, 28 deletions
diff --git a/sql/sql_select.cc b/sql/sql_select.cc
index 45defba4a94..1d7187824fe 100644
--- a/sql/sql_select.cc
+++ b/sql/sql_select.cc
@@ -1771,41 +1771,37 @@ update_ref_and_keys(THD *thd, DYNAMIC_ARRAY *keyuse,JOIN_TAB *join_tab,
uint tables, COND *cond, table_map normal_tables)
{
uint and_level,i,found_eq_constant;
+ KEY_FIELD *key_fields, *end, *field;
+ if (!(key_fields=(KEY_FIELD*)
+ thd->alloc(sizeof(key_fields[0])*(thd->cond_count+1)*2)))
+ return TRUE; /* purecov: inspected */
+ and_level=0; field=end=key_fields;
+ if (my_init_dynamic_array(keyuse,sizeof(KEYUSE),20,64))
+ return TRUE;
+ if (cond)
{
- KEY_FIELD *key_fields,*end;
- KEY_FIELD *field;
-
- if (!(key_fields=(KEY_FIELD*)
- thd->alloc(sizeof(key_fields[0])*(thd->cond_count+1)*2)))
- return TRUE; /* purecov: inspected */
- and_level=0; field=end=key_fields;
- if (my_init_dynamic_array(keyuse,sizeof(KEYUSE),20,64))
- return TRUE;
- if (cond)
+ add_key_fields(join_tab,&end,&and_level,cond,normal_tables);
+ for (; field != end ; field++)
{
- add_key_fields(join_tab,&end,&and_level,cond,normal_tables);
- for (; field != end ; field++)
- {
- add_key_part(keyuse,field);
- /* Mark that we can optimize LEFT JOIN */
- if (field->val->type() == Item::NULL_ITEM &&
- !field->field->real_maybe_null())
- field->field->table->reginfo.not_exists_optimize=1;
- }
+ add_key_part(keyuse,field);
+ /* Mark that we can optimize LEFT JOIN */
+ if (field->val->type() == Item::NULL_ITEM &&
+ !field->field->real_maybe_null())
+ field->field->table->reginfo.not_exists_optimize=1;
}
- for (i=0 ; i < tables ; i++)
+ }
+ for (i=0 ; i < tables ; i++)
+ {
+ if (join_tab[i].on_expr)
{
- if (join_tab[i].on_expr)
- {
- add_key_fields(join_tab,&end,&and_level,join_tab[i].on_expr,
- join_tab[i].table->map);
- }
+ add_key_fields(join_tab,&end,&and_level,join_tab[i].on_expr,
+ join_tab[i].table->map);
}
- /* fill keyuse with found key parts */
- for (; field != end ; field++)
- add_key_part(keyuse,field);
}
+ /* fill keyuse with found key parts */
+ for (; field != end ; field++)
+ add_key_part(keyuse,field);
if (thd->lex.select->ftfunc_list.elements)
{