summaryrefslogtreecommitdiff
path: root/sql/sql_select.cc
diff options
context:
space:
mode:
authorSergei Petrunia <psergey@askmonty.org>2020-06-13 16:45:55 +0300
committerSergei Petrunia <psergey@askmonty.org>2020-06-14 10:40:56 +0300
commit21e79331c8c89e397d5a1ca4a4b8a70ad7c0377a (patch)
treeeeff9cc48b4b915a1fb89ab2bce3e363d41d1c9b /sql/sql_select.cc
parent2cd6afb08372dac6220f69fbb6b44d2d2e964cfc (diff)
downloadmariadb-git-21e79331c8c89e397d5a1ca4a4b8a70ad7c0377a.tar.gz
MDEV-22779: Crash: Prepared Statement with a '?' parameter inside a re-used CTE
When a prepared statement parameter '?' is used in a CTE that is used multiple times, the following happens: - The CTE definition is re-parsed multiple times. - There are multiple Item_param objects referring to the same "?" in the original query. - Prepared_statement::param has a pointer to the first of them, the others are "clones". - When prepared statement parameter gets the value, it should be passed over to clones with param->sync_clones() call. This call is made in insert_params(), etc. It was not made in insert_params_with_log(). This would cause Item_param to not have any value which would confuse the query optimizer. Added the missing call.
Diffstat (limited to 'sql/sql_select.cc')
-rw-r--r--sql/sql_select.cc1
1 files changed, 1 insertions, 0 deletions
diff --git a/sql/sql_select.cc b/sql/sql_select.cc
index b558445540d..4cca2d67eb8 100644
--- a/sql/sql_select.cc
+++ b/sql/sql_select.cc
@@ -5997,6 +5997,7 @@ static void optimize_keyuse(JOIN *join, DYNAMIC_ARRAY *keyuse_array)
uint n_tables= my_count_bits(map);
if (n_tables == 1) // Only one table
{
+ DBUG_ASSERT(!(map & PSEUDO_TABLE_BITS)); // Must be a real table
Table_map_iterator it(map);
int tablenr= it.next_bit();
DBUG_ASSERT(tablenr != Table_map_iterator::BITMAP_END);