diff options
author | monty@hundin.mysql.fi <> | 2002-12-03 13:08:25 +0200 |
---|---|---|
committer | monty@hundin.mysql.fi <> | 2002-12-03 13:08:25 +0200 |
commit | 8830eb4aa9fcfd4467407a8c1236d24c2af6bdfb (patch) | |
tree | 4cad7c11d248679cf59fce6e92c37d2d7dc6e486 /sql/sql_select.h | |
parent | ce56f927fa2a059f02654b30537f9da2afdd1d33 (diff) | |
download | mariadb-git-8830eb4aa9fcfd4467407a8c1236d24c2af6bdfb.tar.gz |
Change of internal key_field=NULL handling to avoid error messages.
Optimized SELECT DISTINCT ... ORDER BY ... LIMIT
Fixed reference to uninitalized variable
Diffstat (limited to 'sql/sql_select.h')
-rw-r--r-- | sql/sql_select.h | 18 |
1 files changed, 9 insertions, 9 deletions
diff --git a/sql/sql_select.h b/sql/sql_select.h index a90b2fe3582..d0e10f75727 100644 --- a/sql/sql_select.h +++ b/sql/sql_select.h @@ -247,12 +247,12 @@ class store_key_field: public store_key copy_field.set(to_field,from_field,0); } } - bool copy() - { - copy_field.do_copy(©_field); - return err != 0; - } - const char *name() const { return field_name; } + bool copy() + { + copy_field.do_copy(©_field); + return err != 0; + } + const char *name() const { return field_name; } }; @@ -269,8 +269,7 @@ public: {} bool copy() { - item->save_in_field(to_field); - return err != 0; + return item->save_in_field(to_field, 1) || err != 0; } const char *name() const { return "func"; } }; @@ -293,7 +292,8 @@ public: if (!inited) { inited=1; - item->save_in_field(to_field); + if (item->save_in_field(to_field, 1)) + err= 1; } return err != 0; } |