diff options
author | unknown <timour@mysql.com> | 2004-09-10 04:45:15 +0300 |
---|---|---|
committer | unknown <timour@mysql.com> | 2004-09-10 04:45:15 +0300 |
commit | 4f1d7b7dae6c8df9f336b0b00429da2f759afdc2 (patch) | |
tree | 318c6766b760f52a124018a2ca9492d097590b09 /sql/sql_select.h | |
parent | d9450332927128073e353f11269eba5f0e4ad941 (diff) | |
download | mariadb-git-4f1d7b7dae6c8df9f336b0b00429da2f759afdc2.tar.gz |
Implementation of the last review comments for WL#1724
"Min/Max Optimization for Queries with Group By Clause"
mysql-test/r/group_min_max.result:
Added new test
mysql-test/t/group_min_max.test:
Added new test & comments
sql/item.h:
Remove processor methods that are no longer used.
sql/item_sum.cc:
Remove processor methods that are no longer used.
sql/item_sum.h:
Remove processor methods that are no longer used.
sql/opt_range.cc:
- the test procedure no longer needs to build lists and to traverse the expression trees
- all usable indexes are tested and the bes one is chosen
- added/edited function comments
sql/sql_select.cc:
Modified make_sum_func_list() so it can be reused in the test for MIN/MAX optimization.
sql/sql_select.h:
Modified make_sum_func_list() so it can be reused in the test for MIN/MAX optimization.
Diffstat (limited to 'sql/sql_select.h')
-rw-r--r-- | sql/sql_select.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/sql/sql_select.h b/sql/sql_select.h index 03c778637fd..b1af15017cc 100644 --- a/sql/sql_select.h +++ b/sql/sql_select.h @@ -303,7 +303,7 @@ class JOIN :public Sql_alloc void restore_tmp(); bool alloc_func_list(); bool make_sum_func_list(List<Item> &all_fields, List<Item> &send_fields, - bool before_group_by); + bool before_group_by, bool recompute= FALSE); inline void set_items_ref_array(Item **ptr) { |