diff options
author | Sergei Petrunia <psergey@askmonty.org> | 2016-02-04 18:41:50 +0300 |
---|---|---|
committer | Sergei Petrunia <psergey@askmonty.org> | 2016-02-14 11:13:45 +0300 |
commit | 426cd232a7fed0a55403aa9e42c0dd05dedd8b58 (patch) | |
tree | cc211d18511ccf959a58c439de6103a88fdca1ac /sql/sql_select.h | |
parent | c17f1df87b51493762e48380ef198f9af98363a2 (diff) | |
download | mariadb-git-426cd232a7fed0a55403aa9e42c0dd05dedd8b58.tar.gz |
Window functions: moving ahead
Disable the code that attempts to group window functions together
by their PARTITION BY / ORDER BY clauses, because
1. It doesn't work: when I issue a query with just one window function,
and no indexes on the table, filesort is not invoked at all.
2. It is not possible to check that it works currently.
Add my own code that does invoke filesort() for each window function.
- Hopefully the sort criteria is right
- Debugging shows that filesort operates on {sort_key, rowid} pairs (OK)
- We can read the filesort rowid result in order.
Diffstat (limited to 'sql/sql_select.h')
-rw-r--r-- | sql/sql_select.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/sql/sql_select.h b/sql/sql_select.h index 5aa1924adfa..a75662dd1c7 100644 --- a/sql/sql_select.h +++ b/sql/sql_select.h @@ -1519,7 +1519,7 @@ public: int init_execution(); void exec(); - void process_window_functions(List<Item> *curr_fields_list); + bool process_window_functions(List<Item> *curr_fields_list); void exec_inner(); bool prepare_result(List<Item> **columns_list); |