summaryrefslogtreecommitdiff
path: root/sql/sql_signal.cc
diff options
context:
space:
mode:
authorAlexander Nozdrin <alik@sun.com>2010-05-14 22:11:25 +0400
committerAlexander Nozdrin <alik@sun.com>2010-05-14 22:11:25 +0400
commit6facd4cb13170e8695d9ae4f1e30611af0b0a472 (patch)
tree288d8745f229bd71630b65bb9f3cbd594db8d7e8 /sql/sql_signal.cc
parent4333980a493e7062e108899b34cc809b03862c34 (diff)
downloadmariadb-git-6facd4cb13170e8695d9ae4f1e30611af0b0a472.tar.gz
Patch for Bug#27863 (excessive memory usage for many small queries in a
multiquery packet). Background: - a query can contain multiple SQL statements; - the server frees resources allocated to process a query when the whole query is handled. In other words, resources allocated to process one SQL statement from a multi-statement query are freed when all SQL statements are handled. The problem was that the parser allocated a buffer of size of the whole query for each SQL statement in a multi-statement query. Thus, if a query had many SQL-statements (so, the query was long), but each SQL statement was short, ther parser tried to allocate huge amount of memory (number of small SQL statements * length of the whole query). The memory was allocated for a so-called "cpp buffer", which is intended to store pre-processed SQL statement -- SQL text without version specific comments. The fix is to allocate memory for the "cpp buffer" once for all SQL statements (once for a query).
Diffstat (limited to 'sql/sql_signal.cc')
-rw-r--r--sql/sql_signal.cc4
1 files changed, 0 insertions, 4 deletions
diff --git a/sql/sql_signal.cc b/sql/sql_signal.cc
index 8ba9cb369aa..f340da373e8 100644
--- a/sql/sql_signal.cc
+++ b/sql/sql_signal.cc
@@ -75,10 +75,6 @@ const LEX_STRING Diag_statement_item_names[]=
{ C_STRING_WITH_LEN("TRANSACTION_ACTIVE") }
};
-Set_signal_information::Set_signal_information()
-{
- clear();
-}
Set_signal_information::Set_signal_information(
const Set_signal_information& set)