diff options
| author | gkodinov/kgeorge@macbook.gmz <> | 2006-10-17 16:20:26 +0300 |
|---|---|---|
| committer | gkodinov/kgeorge@macbook.gmz <> | 2006-10-17 16:20:26 +0300 |
| commit | f7b8937661e3c8ceb1e16a868c92585b2c66d01c (patch) | |
| tree | e9d042b9e6f984142988ab80b1e498e226ff394a /sql/sql_table.cc | |
| parent | 00a2f232c97c425672d2d71916244557075dc98e (diff) | |
| download | mariadb-git-f7b8937661e3c8ceb1e16a868c92585b2c66d01c.tar.gz | |
Bug#21798: memory leak during query execution with subquery in column
list using a function
When executing dependent subqueries they are re-inited and re-exec() for
each row of the outer context.
The cause for the bug is that during subquery reinitialization/re-execution,
the optimizer reallocates JOIN::join_tab, JOIN::table in make_simple_join()
and the local variable in 'sortorder' in create_sort_index(), which is
allocated by make_unireg_sortorder().
Care must be taken not to allocate anything into the thread's memory pool
while re-initializing query plan structures between subquery re-executions.
All such items mush be cached and reused because the thread's memory pool
is freed at the end of the whole query.
Note that they must be cached and reused even for queries that are not
otherwise cacheable because otherwise it will grow the thread's memory
pool every time a cacheable query is re-executed.
We provide additional members to the JOIN structure to store references
to the items that need to be cached.
Diffstat (limited to 'sql/sql_table.cc')
| -rw-r--r-- | sql/sql_table.cc | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/sql/sql_table.cc b/sql/sql_table.cc index e065a32c2e8..08c7e03693e 100644 --- a/sql/sql_table.cc +++ b/sql/sql_table.cc @@ -4044,7 +4044,7 @@ copy_data_between_tables(TABLE *from,TABLE *to, if (thd->lex->select_lex.setup_ref_array(thd, order_num) || setup_order(thd, thd->lex->select_lex.ref_pointer_array, &tables, fields, all_fields, order) || - !(sortorder=make_unireg_sortorder(order, &length)) || + !(sortorder=make_unireg_sortorder(order, &length, NULL)) || (from->sort.found_records = filesort(thd, from, sortorder, length, (SQL_SELECT *) 0, HA_POS_ERROR, &examined_rows)) == |