summaryrefslogtreecommitdiff
path: root/sql/sql_table.cc
diff options
context:
space:
mode:
authorjoreland@mysql.com <>2005-01-10 11:17:01 +0100
committerjoreland@mysql.com <>2005-01-10 11:17:01 +0100
commitc9f7f0ffcf5f117f0f65fc9e375e13f394b0f87b (patch)
treef1b37661167886ecfe8944b51fe5b5f64efa94f1 /sql/sql_table.cc
parent50c3a883b2a414e2657cb7e5c47277f99977d37e (diff)
downloadmariadb-git-c9f7f0ffcf5f117f0f65fc9e375e13f394b0f87b.tar.gz
bug#7761 - ndb does not autocommit during alter table
Diffstat (limited to 'sql/sql_table.cc')
-rw-r--r--sql/sql_table.cc24
1 files changed, 13 insertions, 11 deletions
diff --git a/sql/sql_table.cc b/sql/sql_table.cc
index 43f466282b1..52f178946c4 100644
--- a/sql/sql_table.cc
+++ b/sql/sql_table.cc
@@ -3447,6 +3447,19 @@ copy_data_between_tables(TABLE *from,TABLE *to,
if (!(copy= new Copy_field[to->fields]))
DBUG_RETURN(-1); /* purecov: inspected */
+ /*
+ Turn off recovery logging since rollback of an alter table is to
+ delete the new table so there is no need to log the changes to it.
+
+ This needs to be done before external_lock
+ */
+ error= ha_enable_transaction(thd,FALSE);
+ if (error)
+ {
+ DBUG_RETURN(-1);
+ }
+
+
if (to->file->external_lock(thd, F_WRLCK))
DBUG_RETURN(-1);
from->file->info(HA_STATUS_VARIABLE);
@@ -3502,17 +3515,6 @@ copy_data_between_tables(TABLE *from,TABLE *to,
goto err;
};
- /*
- Turn off recovery logging since rollback of an alter table is to
- delete the new table so there is no need to log the changes to it.
- */
- error= ha_enable_transaction(thd,FALSE);
- if (error)
- {
- error= 1;
- goto err;
- }
-
/* Handler must be told explicitly to retrieve all columns, because
this function does not set field->query_id in the columns to the
current query id */