diff options
| author | Igor Babaev <igor@askmonty.org> | 2021-03-03 22:48:39 -0800 |
|---|---|---|
| committer | Igor Babaev <igor@askmonty.org> | 2021-03-03 22:49:29 -0800 |
| commit | 08d8bce583227a25b4f646fa9a836f7893badd9a (patch) | |
| tree | 9cc6227d699b7ae4e267085663f30bd4b6d4e318 /sql/sql_tvc.cc | |
| parent | 5bd994b0d56d11bf62717a84172c49ca9ed37de4 (diff) | |
| download | mariadb-git-08d8bce583227a25b4f646fa9a836f7893badd9a.tar.gz | |
MDEV-22786 Crashes with nested table value constructors
The bug caused crashes of the server when processing queries with nested
table value constructors (TVC) . It happened because the grammar rules to
parse TVC used the same global lists for both nested TVC and nesting TVC.
As a result invalid select trees were constructed for queries with nested
TVC and this led to crashes at the prepare stage.
This patch provides its own lists structures for each TVC nest level.
Besides the patch fixes a bug in the function wrap_tvc() that missed
inheritance of the SELECT_LEX::exclude_from_table_unique_test for
selects that wrapped TVCs. This inheritance is critical for specifications
of derived tables that employ nested TVCs.
Approved by dmitry.shulga@mariadb.com
Diffstat (limited to 'sql/sql_tvc.cc')
| -rw-r--r-- | sql/sql_tvc.cc | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/sql/sql_tvc.cc b/sql/sql_tvc.cc index cb056b0e15f..96c5223ee6a 100644 --- a/sql/sql_tvc.cc +++ b/sql/sql_tvc.cc @@ -673,6 +673,8 @@ st_select_lex *wrap_tvc(THD *thd, st_select_lex *tvc_sl, wrapper_sl->nest_level= tvc_sl->nest_level; wrapper_sl->parsing_place= tvc_sl->parsing_place; wrapper_sl->linkage= tvc_sl->linkage; + wrapper_sl->exclude_from_table_unique_test= + tvc_sl->exclude_from_table_unique_test; lex->current_select= wrapper_sl; item= new (thd->mem_root) Item_field(thd, &wrapper_sl->context, |