diff options
| author | cmiller@zippy.cornsilk.net <> | 2006-10-03 13:38:25 -0400 |
|---|---|---|
| committer | cmiller@zippy.cornsilk.net <> | 2006-10-03 13:38:25 -0400 |
| commit | 5512100c6aa1cfc49cbfb369c6ddf4079b47238c (patch) | |
| tree | d5a05af2d246695f683a48051134ed0526ea254e /sql/sql_view.h | |
| parent | 46b3997c514fac4b991209d8679b12698bf5103f (diff) | |
| download | mariadb-git-5512100c6aa1cfc49cbfb369c6ddf4079b47238c.tar.gz | |
Bug #14262: SP: DROP PROCEDURE|VIEW (maybe more) write to binlog too late \
(race cond)
It was possible for one thread to interrupt a Data Definition Language
statement and thereby get messages to the binlog out of order. Consider:
Connection 1: Drop Foo x
Connection 2: Create or replace Foo x
Connection 2: Log "Create or replace Foo x"
Connection 1: Log "Drop Foo x"
Local end would have Foo x, but the replicated slaves would not.
The fix for this is to wrap all DDL and logging of a kind in the same mutex.
Since we already use mutexes for the various parts of altering the server,
this only entails moving the logging events down close to the action, inside
the mutex protection.
Diffstat (limited to 'sql/sql_view.h')
| -rw-r--r-- | sql/sql_view.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/sql/sql_view.h b/sql/sql_view.h index cd61d7e9e71..9b6856b8c8a 100644 --- a/sql/sql_view.h +++ b/sql/sql_view.h @@ -16,7 +16,7 @@ Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA */ -bool mysql_create_view(THD *thd, +bool mysql_create_view(THD *thd, TABLE_LIST *view, enum_view_create_mode mode); bool mysql_make_view(THD *thd, File_parser *parser, TABLE_LIST *table); |