diff options
| author | unknown <aelkin/elkin@dsl-hkibras-fe30f900-107.dhcp.inet.fi> | 2006-11-26 15:55:49 +0200 |
|---|---|---|
| committer | unknown <aelkin/elkin@dsl-hkibras-fe30f900-107.dhcp.inet.fi> | 2006-11-26 15:55:49 +0200 |
| commit | 2138534c134c89eb68cf17a3c7534a3459c1ea5b (patch) | |
| tree | 51ccaf3cdbfa729c3f3d2799e2fa10b015e47e86 /sql/table.cc | |
| parent | d3f711fafc4928f941b8fc2fbceed5109b5d8bde (diff) | |
| download | mariadb-git-2138534c134c89eb68cf17a3c7534a3459c1ea5b.tar.gz | |
Bug #24487 Valgrind: uninited byte in table->record[1] in binlog code for rbr + innodb
The reason of this valgrind's compaint is not a bug but rather a feature of bitwise ops:
for any value of the byte x
x | 1 -> 1, and x & 0 -> 0.
x, being a null_byte part of record[1] can be left unassigned even after
ha_innobase::index_read_idx because the above and still be correct.
Addding a check memory upon the invocation of the function can detect this fact
long before record[1], old record, is eventually passed to my_write.
Fixed with initialization of record[1]'s null_bytes part in open_table_from_share.
sql/table.cc:
initializing part of record[1]
Diffstat (limited to 'sql/table.cc')
| -rw-r--r-- | sql/table.cc | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/sql/table.cc b/sql/table.cc index 7f80b95c954..1506c1220d7 100644 --- a/sql/table.cc +++ b/sql/table.cc @@ -1400,6 +1400,7 @@ int open_table_from_share(THD *thd, TABLE_SHARE *share, const char *alias, if (records > 1) { memcpy(outparam->record[0], share->default_values, share->rec_buff_length); + memcpy(outparam->record[1], share->default_values, share->null_bytes); if (records > 2) memcpy(outparam->record[1], share->default_values, share->rec_buff_length); |