cleanup: remove TABLE::add_read_columns_used_by_index

TABLE::add_read_columns_used_by_index() is conceptually wrong,
it *adds* columns used by index to the bitmap, without clearing
it first. But it also enables keyread, meaning that *only* columns
from the index will be read. It is supposed to be used to
add columns used by an index to a bitmap that already has columns
of a primary key - for engines where a primary key is part of every
index.

The correct fix is to change mark_columns_used_by_index() to
take into account extended keys.

this reverts 1d0acc7754a44613d2ad and cf97cbd1db762c443aa3

1 files changed, 0 insertions, 1 deletions

diff --git a/sql/table.h b/sql/table.h
index 845c94b11c4..61efea0c5b3 100644
--- a/sql/table.h
+++ b/sql/table.h
@@ -1310,7 +1310,6 @@ public:
   MY_BITMAP *mark_columns_used_by_index_in_bitmap(uint index, MY_BITMAP *map);
   MY_BITMAP *mark_columns_used_by_index(uint index)
   { return mark_columns_used_by_index_in_bitmap(index, &tmp_set); }
-  void add_read_columns_used_by_index(uint index);
   void restore_column_maps_after_mark_index(MY_BITMAP *backup);
   void mark_auto_increment_column(void);
   void mark_columns_needed_for_update(void);