diff options
author | Daniele Sciascia <daniele.sciascia@galeracluster.com> | 2020-03-21 08:17:28 +0100 |
---|---|---|
committer | GitHub <noreply@github.com> | 2020-03-21 09:17:28 +0200 |
commit | 9394cc89143e4fce3126a96ac1c8a91a66d71dea (patch) | |
tree | d21d24e28e3c28ac25815e4509b146f5e9774d97 /sql/wsrep_mysqld.h | |
parent | bd3c8f47cd16b4795dd073bbd30decd804c76969 (diff) | |
download | mariadb-git-9394cc89143e4fce3126a96ac1c8a91a66d71dea.tar.gz |
MDEV-21675: Data inconsistency after multirow insert rollback (#1474)
* Remove dead code
* MDEV-21675 Data inconsistency after multirow insert rollback
This patch fixes data inconsistencies that happen after rollback of
multirow inserts, with binlog disabled.
For example, statements such as `INSERT INTO t1 VALUES (1,'a'),(1,'b')`
that fail with duplicate key error. In such cases the whole statement
is rolled back. However, with wsrep_emulate_binlog in effect, the
IO_CACHE would not be truncated, and the pending rows events would be
replicated to the rest of the cluster. In the above example, it would
result in row (1,'a') being replicated, whereas locally the statement
is rolled back entirely. Making the cluster inconsistent.
The patch changes the code so that prior to statement rollback,
pending rows event are removed and the stmt cache reset.
That patch also introduces MTR tests that excercise multirow insert
statements for regular, and streaming replication.
Diffstat (limited to 'sql/wsrep_mysqld.h')
-rw-r--r-- | sql/wsrep_mysqld.h | 5 |
1 files changed, 0 insertions, 5 deletions
diff --git a/sql/wsrep_mysqld.h b/sql/wsrep_mysqld.h index 71cbc875b91..a5da8e3bc44 100644 --- a/sql/wsrep_mysqld.h +++ b/sql/wsrep_mysqld.h @@ -405,11 +405,6 @@ extern void wsrep_handle_mdl_conflict(MDL_context *requestor_ctx, MDL_ticket *ticket, const MDL_key *key); -IO_CACHE * get_trans_log(THD * thd); -bool wsrep_trans_cache_is_empty(THD *thd); -void thd_binlog_flush_pending_rows_event(THD *thd, bool stmt_end); -void thd_binlog_rollback_stmt(THD * thd); -void thd_binlog_trx_reset(THD * thd); enum wsrep_thread_type { WSREP_APPLIER_THREAD=1, |