diff options
author | Michael Widenius <monty@mariadb.org> | 2014-03-19 15:18:29 +0200 |
---|---|---|
committer | Michael Widenius <monty@mariadb.org> | 2014-03-19 15:18:29 +0200 |
commit | d1655ba6c42fd0fff13077587711b0d6f048146d (patch) | |
tree | 0f5a51f2cf28cfc1e61f8267ed8e46eafcd44659 /sql | |
parent | 7ba9f0640efe2887da8d1dc4bd5f1aa3d633fc65 (diff) | |
parent | 913d1f199c1e21edef4c373a29eef22aa2bc71ed (diff) | |
download | mariadb-git-d1655ba6c42fd0fff13077587711b0d6f048146d.tar.gz |
Automatic merge
Diffstat (limited to 'sql')
-rw-r--r-- | sql/sql_base.cc | 6 | ||||
-rw-r--r-- | sql/sql_table.cc | 19 |
2 files changed, 24 insertions, 1 deletions
diff --git a/sql/sql_base.cc b/sql/sql_base.cc index bb15562b8f8..918da90e875 100644 --- a/sql/sql_base.cc +++ b/sql/sql_base.cc @@ -656,6 +656,12 @@ static void mark_temp_tables_as_free_for_reuse(THD *thd) { DBUG_ENTER("mark_temp_tables_as_free_for_reuse"); + if (thd->query_id == 0) + { + /* Thread has not executed any statement and has not used any tmp tables */ + DBUG_VOID_RETURN; + } + thd->lock_temporary_tables(); for (TABLE *table= thd->temporary_tables ; table ; table= table->next) { diff --git a/sql/sql_table.cc b/sql/sql_table.cc index bee2ad64626..8e9601c437e 100644 --- a/sql/sql_table.cc +++ b/sql/sql_table.cc @@ -2560,6 +2560,18 @@ err: error= 1; } + /* + We are always logging drop of temporary tables. + The reason is to handle the following case: + - Use statement based replication + - CREATE TEMPORARY TABLE foo (logged) + - set row based replication + - DROP TEMPORAY TABLE foo (needs to be logged) + This should be fixed so that we remember if creation of the + temporary table was logged and only log it if the creation was + logged. + */ + if (non_trans_tmp_table_deleted || trans_tmp_table_deleted || non_tmp_table_deleted) { @@ -4628,6 +4640,7 @@ int create_table_impl(THD *thd, thd->variables.option_bits|= OPTION_KEEP_LOG; thd->log_current_statement= 1; create_info->table_was_deleted= 1; + DBUG_EXECUTE_IF("send_kill_after_delete", thd->killed= KILL_QUERY; ); /* The test of query_tables is to ensure we have any tables in the @@ -4769,6 +4782,7 @@ int create_table_impl(THD *thd, err: THD_STAGE_INFO(thd, stage_after_create); delete file; + DBUG_PRINT("exit", ("return: %d", error)); DBUG_RETURN(error); warn: @@ -5262,7 +5276,8 @@ bool mysql_create_like_table(THD* thd, TABLE_LIST* table, char buf[2048]; String query(buf, sizeof(buf), system_charset_info); query.length(0); // Have to zero it since constructor doesn't - Open_table_context ot_ctx(thd, MYSQL_OPEN_REOPEN); + Open_table_context ot_ctx(thd, MYSQL_OPEN_REOPEN | + MYSQL_OPEN_IGNORE_KILLED); bool new_table= FALSE; // Whether newly created table is open. if (create_res != 0) @@ -5271,6 +5286,7 @@ bool mysql_create_like_table(THD* thd, TABLE_LIST* table, Table or view with same name already existed and we where using IF EXISTS. Continue without logging anything. */ + do_logging= 0; goto err; } if (!table->table) @@ -5316,6 +5332,7 @@ bool mysql_create_like_table(THD* thd, TABLE_LIST* table, if (write_bin_log(thd, TRUE, query.ptr(), query.length())) { res= 1; + do_logging= 0; goto err; } |