summaryrefslogtreecommitdiff
path: root/sql
diff options
context:
space:
mode:
authorGeorgi Kodinov <joro@sun.com>2009-08-21 17:41:48 +0300
committerGeorgi Kodinov <joro@sun.com>2009-08-21 17:41:48 +0300
commit787a4940cabef1416dbba1942ee3a07b987e9338 (patch)
treee6c13b235af5125765f617afc9861d0273a62159 /sql
parentb011f1ea1c2cff73706f8b3ef8eacea2c433a9d9 (diff)
parent8723e9d2269fec4d0a7dd4796deb53c0b2eab804 (diff)
downloadmariadb-git-787a4940cabef1416dbba1942ee3a07b987e9338.tar.gz
reverted the fix for bug #46019 from 5.1-bugteam
Diffstat (limited to 'sql')
-rw-r--r--sql/sql_acl.cc9
-rw-r--r--sql/sql_parse.cc3
-rw-r--r--sql/table.h9
3 files changed, 3 insertions, 18 deletions
diff --git a/sql/sql_acl.cc b/sql/sql_acl.cc
index de132d169f2..ab18a2d1d04 100644
--- a/sql/sql_acl.cc
+++ b/sql/sql_acl.cc
@@ -3905,15 +3905,11 @@ bool check_grant(THD *thd, ulong want_access, TABLE_LIST *tables,
continue; // ok
if (!(~table->grant.privilege & want_access) ||
- (table->is_anonymous_derived_table() &&
- table->is_non_materialized_derived_table()) || table->schema_table)
+ table->is_anonymous_derived_table() || table->schema_table)
{
/*
It is subquery in the FROM clause. VIEW set table->derived after
- table opening, but this function is mostly called before table opening.
- When it's called after table opening e.g. for nested views with
- materialization we shoud check the materialized table for access as
- any other table.
+ table opening, but this function always called before table opening.
*/
if (!table->referencing_view)
{
@@ -3926,7 +3922,6 @@ bool check_grant(THD *thd, ulong want_access, TABLE_LIST *tables,
}
continue;
}
-
if (!(grant_table= table_hash_search(sctx->host, sctx->ip,
table->get_db_name(), sctx->priv_user,
table->get_table_name(), FALSE)))
diff --git a/sql/sql_parse.cc b/sql/sql_parse.cc
index de5f2838edd..fb5d58b63c4 100644
--- a/sql/sql_parse.cc
+++ b/sql/sql_parse.cc
@@ -5058,8 +5058,7 @@ bool check_single_table_access(THD *thd, ulong privilege,
if (!(all_tables->belong_to_view &&
(thd->lex->sql_command == SQLCOM_SHOW_FIELDS)) &&
!(all_tables->view &&
- all_tables->effective_algorithm == VIEW_ALGORITHM_TMPTABLE &&
- all_tables->is_non_materialized_derived_table()) &&
+ all_tables->effective_algorithm == VIEW_ALGORITHM_TMPTABLE) &&
check_grant(thd, privilege, all_tables, 0, 1, no_errors))
goto deny;
diff --git a/sql/table.h b/sql/table.h
index 1beea8ac1a1..40372fa91cf 100644
--- a/sql/table.h
+++ b/sql/table.h
@@ -1466,15 +1466,6 @@ struct TABLE_LIST
bool is_anonymous_derived_table() const { return derived && !view; }
/**
- @brief True if this TABLE_LIST represents an not yet materialized
- derived table, i.e. the result of a subquery or view execution.
- */
- bool is_non_materialized_derived_table() const
- {
- return derived && !derived_result;
- }
-
- /**
@brief Returns the name of the database that the referenced table belongs
to.
*/