diff options
| author | unknown <konstantin@oak.local> | 2003-10-31 17:52:00 +0300 |
|---|---|---|
| committer | unknown <konstantin@oak.local> | 2003-10-31 17:52:00 +0300 |
| commit | 9c8d73c72898e35fafd83a56e7f9bc814e514d53 (patch) | |
| tree | 715883a51ea9c662835b72ee24d1326f48d76f02 /sql | |
| parent | 4a3553ed5cb62ce2dc9e515297ffbeaecb666a80 (diff) | |
| download | mariadb-git-9c8d73c72898e35fafd83a56e7f9bc814e514d53.tar.gz | |
follow-up to Sanja fix:
fix_fields() never accepts (THD *)(0)
Diffstat (limited to 'sql')
| -rw-r--r-- | sql/item.cc | 2 | ||||
| -rw-r--r-- | sql/item_cmpfunc.cc | 5 | ||||
| -rw-r--r-- | sql/item_func.cc | 14 |
3 files changed, 8 insertions, 13 deletions
diff --git a/sql/item.cc b/sql/item.cc index 0462a78376f..8262e13a0cb 100644 --- a/sql/item.cc +++ b/sql/item.cc @@ -914,7 +914,7 @@ bool Item_field::fix_fields(THD *thd, TABLE_LIST *tables, Item **ref) set_field(tmp); } - else if (thd && thd->set_query_id && field->query_id != thd->query_id) + else if (thd->set_query_id && field->query_id != thd->query_id) { /* We only come here in unions */ TABLE *table=field->table; diff --git a/sql/item_cmpfunc.cc b/sql/item_cmpfunc.cc index d6c05f47964..407678ac805 100644 --- a/sql/item_cmpfunc.cc +++ b/sql/item_cmpfunc.cc @@ -1614,7 +1614,7 @@ Item_cond::fix_fields(THD *thd, TABLE_LIST *tables, Item **ref) */ and_tables_cache= ~(table_map) 0; - if (thd && check_stack_overrun(thd,buff)) + if (check_stack_overrun(thd, buff)) return 1; // Fatal error flag is set! while ((item=li++)) { @@ -1643,8 +1643,7 @@ Item_cond::fix_fields(THD *thd, TABLE_LIST *tables, Item **ref) if (item->maybe_null) maybe_null=1; } - if (thd) - thd->lex.current_select->cond_count+=list.elements; + thd->lex.current_select->cond_count+=list.elements; fix_length_and_dec(); fixed= 1; return 0; diff --git a/sql/item_func.cc b/sql/item_func.cc index ce0614f1e7c..ac3c53f7bd2 100644 --- a/sql/item_func.cc +++ b/sql/item_func.cc @@ -197,7 +197,7 @@ Item_func::fix_fields(THD *thd, TABLE_LIST *tables, Item **ref) used_tables_cache= not_null_tables_cache= 0; const_item_cache=1; - if (thd && check_stack_overrun(thd,buff)) + if (check_stack_overrun(thd, buff)) return 1; // Fatal error if flag is set! if (arg_count) { // Print purify happy @@ -219,7 +219,7 @@ Item_func::fix_fields(THD *thd, TABLE_LIST *tables, Item **ref) } } fix_length_and_dec(); - if (thd && thd->net.last_errno) // An error inside fix_length_and_dec accured + if (thd->net.last_errno) // An error inside fix_length_and_dec occured return 1; fixed= 1; return 0; @@ -1396,13 +1396,9 @@ udf_handler::fix_fields(THD *thd, TABLE_LIST *tables, Item_result_field *func, #endif DBUG_ENTER("Item_udf_func::fix_fields"); - if (thd) - { - if (check_stack_overrun(thd,buff)) - DBUG_RETURN(1); // Fatal error flag is set! - } - else - thd=current_thd; // In WHERE / const clause + if (check_stack_overrun(thd, buff)) + DBUG_RETURN(1); // Fatal error flag is set! + udf_func *tmp_udf=find_udf(u_d->name.str,(uint) u_d->name.length,1); if (!tmp_udf) |