diff options
| author | Marko Mäkelä <marko.makela@mariadb.com> | 2020-12-09 16:49:52 +0200 |
|---|---|---|
| committer | Marko Mäkelä <marko.makela@mariadb.com> | 2020-12-09 16:49:52 +0200 |
| commit | 0c7c449267655ed759f223067c5095d7df3665b3 (patch) | |
| tree | 75fb309c850a2aa45a9741a7f37719d16c58f8de /storage/innobase/os | |
| parent | 5eb539555b36a60944eefeb84d5d6d436ba61e63 (diff) | |
| download | mariadb-git-0c7c449267655ed759f223067c5095d7df3665b3.tar.gz | |
Remove unused DBUG_EXECUTE_IF "ignore_punch_hole"
Since commit ea21d630be639317be0dc9d2b72a04f3ef3f9c7b we
conditionally define a variable that only plays a role on
systems that support hole-punching (explicit creation of sparse files).
However, that broke debug builds on such systems.
It turns out that the debug_dbug label "ignore_punch_hole" is
not at all used in MariaDB server. It would be covered by
the MySQL 5.7 test innodb.table_compress. (Note: MariaDB 10.1
implemented page_compressed tables before something comparable
appeared in MySQL 5.7.)
Diffstat (limited to 'storage/innobase/os')
| -rw-r--r-- | storage/innobase/os/os0file.cc | 14 |
1 files changed, 0 insertions, 14 deletions
diff --git a/storage/innobase/os/os0file.cc b/storage/innobase/os/os0file.cc index ee7f09ec17f..7286b6b62f5 100644 --- a/storage/innobase/os/os0file.cc +++ b/storage/innobase/os/os0file.cc @@ -3538,13 +3538,6 @@ short_warning: @return true if the file system supports sparse files */ IF_WIN(static,) bool os_is_sparse_file_supported(os_file_t fh) { - /* In this debugging mode, we act as if punch hole is supported, - then we skip any calls to actually punch a hole. In this way, - Transparent Page Compression is still being tested. */ - DBUG_EXECUTE_IF("ignore_punch_hole", - return(true); - ); - #ifdef _WIN32 FILE_ATTRIBUTE_TAG_INFO info; if (GetFileInformationByHandleEx(fh, FileAttributeTagInfo, @@ -3795,13 +3788,6 @@ os_file_punch_hole( @return DB_SUCCESS or error code */ dberr_t IORequest::punch_hole(os_offset_t off, ulint len) const { - /* In this debugging mode, we act as if punch hole is supported, - and then skip any calls to actually punch a hole here. - In this way, Transparent Page Compression is still being tested. */ - DBUG_EXECUTE_IF("ignore_punch_hole", - return(DB_SUCCESS); - ); - ulint trim_len = bpage ? bpage->physical_size() - len : 0; if (trim_len == 0) { |