diff options
| author | Guilhem Bichot <guilhem@mysql.com> | 2009-02-09 22:02:04 +0100 |
|---|---|---|
| committer | Guilhem Bichot <guilhem@mysql.com> | 2009-02-09 22:02:04 +0100 |
| commit | 554eb6c2cf00d80d283374a749ca82f1a1f13bae (patch) | |
| tree | 081daba895f569ca256b27da2c8201393bd9445e /storage/maria/ma_pagecache.c | |
| parent | 790fbc566eabdcb59802ff165d04facf98ed15b0 (diff) | |
| download | mariadb-git-554eb6c2cf00d80d283374a749ca82f1a1f13bae.tar.gz | |
Comments. Take bitmap mutex lock when changing bitmap.changed.
storage/maria/ha_maria.cc:
comment
storage/maria/ma_checkpoint.c:
comment
storage/maria/ma_extra.c:
use bitmap mutex when changing bitmap.changed, sounds safer
storage/maria/ma_pagecache.c:
comment
storage/maria/ma_recovery.c:
comments
Diffstat (limited to 'storage/maria/ma_pagecache.c')
| -rw-r--r-- | storage/maria/ma_pagecache.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/storage/maria/ma_pagecache.c b/storage/maria/ma_pagecache.c index 0a5cea8a541..3887d6af7bc 100644 --- a/storage/maria/ma_pagecache.c +++ b/storage/maria/ma_pagecache.c @@ -4227,11 +4227,11 @@ static int flush_cached_blocks(PAGECACHE *pagecache, @todo IO If page is contiguous with next page to flush, group flushes in one single my_pwrite(). */ - /* + /** It is important to use block->hash_link->file below and not 'file', as - the first one is right and the second may have different content (and - this matters for callbacks, bitmap pages and data pages have different - ones). + the first one is right and the second may have different out-of-date + content (see StaleFilePointersInFlush in ma_checkpoint.c). + @todo change argument of functions to be File. */ error= pagecache_fwrite(pagecache, &block->hash_link->file, block->buffer, |