Apply clang-tidy to remove empty constructors / destructors

This patch is the result of running
run-clang-tidy -fix -header-filter=.* -checks='-*,modernize-use-equals-default' .

Code style changes have been done on top. The result of this change
leads to the following improvements:

1. Binary size reduction.
* For a -DBUILD_CONFIG=mysql_release build, the binary size is reduced by
  ~400kb.
* A raw -DCMAKE_BUILD_TYPE=Release reduces the binary size by ~1.4kb.

2. Compiler can better understand the intent of the code, thus it leads
   to more optimization possibilities. Additionally it enabled detecting
   unused variables that had an empty default constructor but not marked
   so explicitly.

   Particular change required following this patch in sql/opt_range.cc

   result_keys, an unused template class Bitmap now correctly issues
   unused variable warnings.

   Setting Bitmap template class constructor to default allows the compiler
   to identify that there are no side-effects when instantiating the class.
   Previously the compiler could not issue the warning as it assumed Bitmap
   class (being a template) would not be performing a NO-OP for its default
   constructor. This prevented the "unused variable warning".

55 files changed, 113 insertions, 212 deletions

diff --git a/storage/perfschema/cursor_by_account.h b/storage/perfschema/cursor_by_account.h
index c14a563b712..fa6aa95fb04 100644
--- a/storage/perfschema/cursor_by_account.h
+++ b/storage/perfschema/cursor_by_account.h
@@ -49,8 +49,7 @@ protected:
   cursor_by_account(const PFS_engine_table_share *share);
 
 public:
-  ~cursor_by_account()
-  {}
+  ~cursor_by_account() = default;
 
 protected:
   virtual void make_row(PFS_account *account)= 0;
diff --git a/storage/perfschema/cursor_by_host.h b/storage/perfschema/cursor_by_host.h
index ac68acf3945..ad81b2b2045 100644
--- a/storage/perfschema/cursor_by_host.h
+++ b/storage/perfschema/cursor_by_host.h
@@ -49,8 +49,7 @@ protected:
   cursor_by_host(const PFS_engine_table_share *share);
 
 public:
-  ~cursor_by_host()
-  {}
+  ~cursor_by_host() = default;
 
 protected:
   virtual void make_row(PFS_host *host)= 0;
diff --git a/storage/perfschema/cursor_by_thread.h b/storage/perfschema/cursor_by_thread.h
index db130088920..83fbbf4f56a 100644
--- a/storage/perfschema/cursor_by_thread.h
+++ b/storage/perfschema/cursor_by_thread.h
@@ -49,8 +49,7 @@ protected:
   cursor_by_thread(const PFS_engine_table_share *share);
 
 public:
-  ~cursor_by_thread()
-  {}
+  ~cursor_by_thread() = default;
 
 protected:
   virtual void make_row(PFS_thread *thread)= 0;
diff --git a/storage/perfschema/cursor_by_thread_connect_attr.h b/storage/perfschema/cursor_by_thread_connect_attr.h
index 69d1b5ec0c0..925ab3bdcc6 100644
--- a/storage/perfschema/cursor_by_thread_connect_attr.h
+++ b/storage/perfschema/cursor_by_thread_connect_attr.h
@@ -69,8 +69,7 @@ protected:
   cursor_by_thread_connect_attr(const PFS_engine_table_share *share);
 
 public:
-  ~cursor_by_thread_connect_attr()
-  {}
+  ~cursor_by_thread_connect_attr() = default;
 
 protected:
   virtual void make_row(PFS_thread *thread, uint ordinal)= 0;
diff --git a/storage/perfschema/cursor_by_user.h b/storage/perfschema/cursor_by_user.h
index 06554ebb228..849f55147a0 100644
--- a/storage/perfschema/cursor_by_user.h
+++ b/storage/perfschema/cursor_by_user.h
@@ -49,8 +49,7 @@ protected:
   cursor_by_user(const PFS_engine_table_share *share);
 
 public:
-  ~cursor_by_user()
-  {}
+  ~cursor_by_user() = default;
 
 protected:
   virtual void make_row(PFS_user *user)= 0;
diff --git a/storage/perfschema/ha_perfschema.cc b/storage/perfschema/ha_perfschema.cc
index 8860046fa26..509d4a26e82 100644
--- a/storage/perfschema/ha_perfschema.cc
+++ b/storage/perfschema/ha_perfschema.cc
@@ -229,8 +229,7 @@ ha_perfschema::ha_perfschema(handlerton *hton, TABLE_SHARE *share)
   : handler(hton, share), m_table_share(NULL), m_table(NULL)
 {}
 
-ha_perfschema::~ha_perfschema()
-{}
+ha_perfschema::~ha_perfschema() = default;
 
 int ha_perfschema::open(const char *name, int mode, uint test_if_locked)
 {
diff --git a/storage/perfschema/pfs_engine_table.cc b/storage/perfschema/pfs_engine_table.cc
index acab0e73a3d..62ed8b2c312 100644
--- a/storage/perfschema/pfs_engine_table.cc
+++ b/storage/perfschema/pfs_engine_table.cc
@@ -438,11 +438,9 @@ int PFS_engine_table::update_row_values(TABLE *,
 class PFS_internal_schema_access : public ACL_internal_schema_access
 {
 public:
-  PFS_internal_schema_access()
-  {}
+  PFS_internal_schema_access() = default;
 
-  ~PFS_internal_schema_access()
-  {}
+  ~PFS_internal_schema_access() = default;
 
   ACL_internal_access_result check(ulong want_access,
                                    ulong *save_priv) const;
diff --git a/storage/perfschema/pfs_engine_table.h b/storage/perfschema/pfs_engine_table.h
index 03a2b6a9d28..428c0e49e17 100644
--- a/storage/perfschema/pfs_engine_table.h
+++ b/storage/perfschema/pfs_engine_table.h
@@ -84,8 +84,7 @@ public:
   void get_normalizer(PFS_instr_class *instr_class);
 
   /** Destructor. */
-  virtual ~PFS_engine_table()
-  {}
+  virtual ~PFS_engine_table() = default;
 
   /**
     Helper, assign a value to a ulong field.
@@ -260,11 +259,9 @@ struct PFS_engine_table_share
 class PFS_readonly_acl : public ACL_internal_table_access
 {
 public:
-  PFS_readonly_acl()
-  {}
+  PFS_readonly_acl() = default;
 
-  ~PFS_readonly_acl()
-  {}
+  ~PFS_readonly_acl() = default;
 
   virtual ACL_internal_access_result check(ulong want_access, ulong *save_priv) const;
 };
@@ -279,11 +276,9 @@ extern PFS_readonly_acl pfs_readonly_acl;
 class PFS_truncatable_acl : public ACL_internal_table_access
 {
 public:
-  PFS_truncatable_acl()
-  {}
+  PFS_truncatable_acl() = default;
 
-  ~PFS_truncatable_acl()
-  {}
+  ~PFS_truncatable_acl() = default;
 
   ACL_internal_access_result check(ulong want_access, ulong *save_priv) const;
 };
@@ -298,11 +293,9 @@ extern PFS_truncatable_acl pfs_truncatable_acl;
 class PFS_updatable_acl : public ACL_internal_table_access
 {
 public:
-  PFS_updatable_acl()
-  {}
+  PFS_updatable_acl() = default;
 
-  ~PFS_updatable_acl()
-  {}
+  ~PFS_updatable_acl() = default;
 
   ACL_internal_access_result check(ulong want_access, ulong *save_priv) const;
 };
@@ -317,11 +310,9 @@ extern PFS_updatable_acl pfs_updatable_acl;
 class PFS_editable_acl : public ACL_internal_table_access
 {
 public:
-  PFS_editable_acl()
-  {}
+  PFS_editable_acl() = default;
 
-  ~PFS_editable_acl()
-  {}
+  ~PFS_editable_acl() = default;
 
   ACL_internal_access_result check(ulong want_access, ulong *save_priv) const;
 };
@@ -335,11 +326,9 @@ extern PFS_editable_acl pfs_editable_acl;
 class PFS_unknown_acl : public ACL_internal_table_access
 {
 public:
-  PFS_unknown_acl()
-  {}
+  PFS_unknown_acl() = default;
 
-  ~PFS_unknown_acl()
-  {}
+  ~PFS_unknown_acl() = default;
 
   ACL_internal_access_result check(ulong want_access, ulong *save_priv) const;
 };
diff --git a/storage/perfschema/pfs_visitor.cc b/storage/perfschema/pfs_visitor.cc
index 097965fde17..e845ddbeb1e 100644
--- a/storage/perfschema/pfs_visitor.cc
+++ b/storage/perfschema/pfs_visitor.cc
@@ -662,8 +662,7 @@ PFS_connection_wait_visitor
   m_index= klass->m_event_name_index;
 }
 
-PFS_connection_wait_visitor::~PFS_connection_wait_visitor()
-{}
+PFS_connection_wait_visitor::~PFS_connection_wait_visitor() = default;
 
 void PFS_connection_wait_visitor::visit_global()
 {
@@ -696,12 +695,9 @@ void PFS_connection_wait_visitor::visit_thread(PFS_thread *pfs)
   m_stat.aggregate(& pfs->m_instr_class_waits_stats[m_index]);
 }
 
-PFS_connection_all_wait_visitor
-::PFS_connection_all_wait_visitor()
-{}
+PFS_connection_all_wait_visitor::PFS_connection_all_wait_visitor() = default;
 
-PFS_connection_all_wait_visitor::~PFS_connection_all_wait_visitor()
-{}
+PFS_connection_all_wait_visitor::~PFS_connection_all_wait_visitor() = default;
 
 void PFS_connection_all_wait_visitor::visit_global()
 {
@@ -744,8 +740,7 @@ PFS_connection_stage_visitor::PFS_connection_stage_visitor(PFS_stage_class *klas
   m_index= klass->m_event_name_index;
 }
 
-PFS_connection_stage_visitor::~PFS_connection_stage_visitor()
-{}
+PFS_connection_stage_visitor::~PFS_connection_stage_visitor() = default;
 
 void PFS_connection_stage_visitor::visit_global()
 {
@@ -778,8 +773,7 @@ PFS_connection_statement_visitor
   m_index= klass->m_event_name_index;
 }
 
-PFS_connection_statement_visitor::~PFS_connection_statement_visitor()
-{}
+PFS_connection_statement_visitor::~PFS_connection_statement_visitor() = default;
 
 void PFS_connection_statement_visitor::visit_global()
 {
@@ -808,11 +802,10 @@ void PFS_connection_statement_visitor::visit_thread(PFS_thread *pfs)
 
 /** Instance wait visitor */
 PFS_connection_all_statement_visitor
-::PFS_connection_all_statement_visitor()
-{}
+::PFS_connection_all_statement_visitor() = default;
 
-PFS_connection_all_statement_visitor::~PFS_connection_all_statement_visitor()
-{}
+PFS_connection_all_statement_visitor
+::~PFS_connection_all_statement_visitor() = default;
 
 void PFS_connection_all_statement_visitor::visit_global()
 {
@@ -854,11 +847,9 @@ void PFS_connection_all_statement_visitor::visit_thread(PFS_thread *pfs)
   visit_connection_slice(pfs);
 }
 
-PFS_connection_stat_visitor::PFS_connection_stat_visitor()
-{}
+PFS_connection_stat_visitor::PFS_connection_stat_visitor() = default;
 
-PFS_connection_stat_visitor::~PFS_connection_stat_visitor()
-{}
+PFS_connection_stat_visitor::~PFS_connection_stat_visitor() = default;
 
 void PFS_connection_stat_visitor::visit_global()
 {}
@@ -883,12 +874,9 @@ void PFS_connection_stat_visitor::visit_thread(PFS_thread *)
   m_stat.aggregate_active(1);
 }
 
-PFS_instance_wait_visitor::PFS_instance_wait_visitor()
-{
-}
+PFS_instance_wait_visitor::PFS_instance_wait_visitor() = default;
 
-PFS_instance_wait_visitor::~PFS_instance_wait_visitor()
-{}
+PFS_instance_wait_visitor::~PFS_instance_wait_visitor() = default;
 
 void PFS_instance_wait_visitor::visit_mutex_class(PFS_mutex_class *pfs)
 {
@@ -948,11 +936,9 @@ void PFS_instance_wait_visitor::visit_socket(PFS_socket *pfs)
 
 /** Table IO wait visitor */
 
-PFS_object_wait_visitor::PFS_object_wait_visitor()
-{}
+PFS_object_wait_visitor::PFS_object_wait_visitor() = default;
 
-PFS_object_wait_visitor::~PFS_object_wait_visitor()
-{}
+PFS_object_wait_visitor::~PFS_object_wait_visitor() = default;
 
 void PFS_object_wait_visitor::visit_global()
 {
@@ -976,11 +962,9 @@ void PFS_object_wait_visitor::visit_table(PFS_table *pfs)
   }
 }
 
-PFS_table_io_wait_visitor::PFS_table_io_wait_visitor()
-{}
+PFS_table_io_wait_visitor::PFS_table_io_wait_visitor() = default;
 
-PFS_table_io_wait_visitor::~PFS_table_io_wait_visitor()
-{}
+PFS_table_io_wait_visitor::~PFS_table_io_wait_visitor() = default;
 
 void PFS_table_io_wait_visitor::visit_global()
 {
@@ -1026,11 +1010,9 @@ void PFS_table_io_wait_visitor::visit_table(PFS_table *pfs)
 
 /** Table IO stat visitor */
 
-PFS_table_io_stat_visitor::PFS_table_io_stat_visitor()
-{}
+PFS_table_io_stat_visitor::PFS_table_io_stat_visitor() = default;
 
-PFS_table_io_stat_visitor::~PFS_table_io_stat_visitor()
-{}
+PFS_table_io_stat_visitor::~PFS_table_io_stat_visitor() = default;
 
 void PFS_table_io_stat_visitor::visit_table_share(PFS_table_share *pfs)
 {
@@ -1065,11 +1047,9 @@ void PFS_table_io_stat_visitor::visit_table(PFS_table *pfs)
 
 /** Index IO stat visitor */
 
-PFS_index_io_stat_visitor::PFS_index_io_stat_visitor()
-{}
+PFS_index_io_stat_visitor::PFS_index_io_stat_visitor() = default;
 
-PFS_index_io_stat_visitor::~PFS_index_io_stat_visitor()
-{}
+PFS_index_io_stat_visitor::~PFS_index_io_stat_visitor() = default;
 
 void PFS_index_io_stat_visitor::visit_table_share_index(PFS_table_share *pfs, uint index)
 {
@@ -1083,11 +1063,9 @@ void PFS_index_io_stat_visitor::visit_table_index(PFS_table *pfs, uint index)
 
 /** Table lock wait visitor */
 
-PFS_table_lock_wait_visitor::PFS_table_lock_wait_visitor()
-{}
+PFS_table_lock_wait_visitor::PFS_table_lock_wait_visitor() = default;
 
-PFS_table_lock_wait_visitor::~PFS_table_lock_wait_visitor()
-{}
+PFS_table_lock_wait_visitor::~PFS_table_lock_wait_visitor() = default;
 
 void PFS_table_lock_wait_visitor::visit_global()
 {
@@ -1106,11 +1084,9 @@ void PFS_table_lock_wait_visitor::visit_table(PFS_table *pfs)
 
 /** Table lock stat visitor */
 
-PFS_table_lock_stat_visitor::PFS_table_lock_stat_visitor()
-{}
+PFS_table_lock_stat_visitor::PFS_table_lock_stat_visitor() = default;
 
-PFS_table_lock_stat_visitor::~PFS_table_lock_stat_visitor()
-{}
+PFS_table_lock_stat_visitor::~PFS_table_lock_stat_visitor() = default;
 
 void PFS_table_lock_stat_visitor::visit_table_share(PFS_table_share *pfs)
 {
@@ -1122,11 +1098,11 @@ void PFS_table_lock_stat_visitor::visit_table(PFS_table *pfs)
   m_stat.aggregate(& pfs->m_table_stat.m_lock_stat);
 }
 
-PFS_instance_socket_io_stat_visitor::PFS_instance_socket_io_stat_visitor()
-{}
+PFS_instance_socket_io_stat_visitor
+::PFS_instance_socket_io_stat_visitor() = default;
 
-PFS_instance_socket_io_stat_visitor::~PFS_instance_socket_io_stat_visitor()
-{}
+PFS_instance_socket_io_stat_visitor
+::~PFS_instance_socket_io_stat_visitor() = default;
 
 void PFS_instance_socket_io_stat_visitor::visit_socket_class(PFS_socket_class *pfs) 
 {
@@ -1141,11 +1117,11 @@ void PFS_instance_socket_io_stat_visitor::visit_socket(PFS_socket *pfs)
 }
 
 
-PFS_instance_file_io_stat_visitor::PFS_instance_file_io_stat_visitor()
-{}
+PFS_instance_file_io_stat_visitor
+::PFS_instance_file_io_stat_visitor() = default;
 
-PFS_instance_file_io_stat_visitor::~PFS_instance_file_io_stat_visitor()
-{}
+PFS_instance_file_io_stat_visitor
+::~PFS_instance_file_io_stat_visitor() = default;
 
 void PFS_instance_file_io_stat_visitor::visit_file_class(PFS_file_class *pfs) 
 {
diff --git a/storage/perfschema/pfs_visitor.h b/storage/perfschema/pfs_visitor.h
index 120b5928045..b6e3569b518 100644
--- a/storage/perfschema/pfs_visitor.h
+++ b/storage/perfschema/pfs_visitor.h
@@ -63,8 +63,8 @@ struct PFS_connection_slice;
 class PFS_connection_visitor
 {
 public:
-  PFS_connection_visitor() {}
-  virtual ~PFS_connection_visitor() {}
+  PFS_connection_visitor() = default;
+  virtual ~PFS_connection_visitor() = default;
   /** Visit all connections. */
   virtual void visit_global() {}
   /** Visit all connections of a host. */
@@ -138,8 +138,8 @@ public:
 class PFS_instance_visitor
 {
 public:
-  PFS_instance_visitor() {}
-  virtual ~PFS_instance_visitor() {}
+  PFS_instance_visitor() = default;
+  virtual ~PFS_instance_visitor() = default;
   /** Visit a mutex class. */
   virtual void visit_mutex_class(PFS_mutex_class *pfs) {}
   /** Visit a rwlock class. */
@@ -249,8 +249,8 @@ public:
 class PFS_object_visitor
 {
 public:
-  PFS_object_visitor() {}
-  virtual ~PFS_object_visitor() {}
+  PFS_object_visitor() = default;
+  virtual ~PFS_object_visitor() = default;
   /** Visit global data. */
   virtual void visit_global() {}
   /** Visit a table share. */
diff --git a/storage/perfschema/table_accounts.h b/storage/perfschema/table_accounts.h
index dfc2cc322e0..7bdcf2ce164 100644
--- a/storage/perfschema/table_accounts.h
+++ b/storage/perfschema/table_accounts.h
@@ -66,8 +66,7 @@ protected:
   table_accounts();
 
 public:
-  ~table_accounts()
-  {}
+  ~table_accounts() = default;
 
 private:
   virtual void make_row(PFS_account *pfs);
diff --git a/storage/perfschema/table_all_instr.h b/storage/perfschema/table_all_instr.h
index 072221ba86e..0c2f3d28cf6 100644
--- a/storage/perfschema/table_all_instr.h
+++ b/storage/perfschema/table_all_instr.h
@@ -82,8 +82,7 @@ protected:
   table_all_instr(const PFS_engine_table_share *share);
 
 public:
-  ~table_all_instr()
-  {}
+  ~table_all_instr() = default;
 
 protected:
   /**
diff --git a/storage/perfschema/table_esgs_by_account_by_event_name.h b/storage/perfschema/table_esgs_by_account_by_event_name.h
index ee855d42818..fcd4a5e33f4 100644
--- a/storage/perfschema/table_esgs_by_account_by_event_name.h
+++ b/storage/perfschema/table_esgs_by_account_by_event_name.h
@@ -106,8 +106,7 @@ protected:
   table_esgs_by_account_by_event_name();
 
 public:
-  ~table_esgs_by_account_by_event_name()
-  {}
+  ~table_esgs_by_account_by_event_name() = default;
 
 protected:
   void make_row(PFS_account *account, PFS_stage_class *klass);
diff --git a/storage/perfschema/table_esgs_by_host_by_event_name.h b/storage/perfschema/table_esgs_by_host_by_event_name.h
index 6042e6396af..006f789b15f 100644
--- a/storage/perfschema/table_esgs_by_host_by_event_name.h
+++ b/storage/perfschema/table_esgs_by_host_by_event_name.h
@@ -106,8 +106,7 @@ protected:
   table_esgs_by_host_by_event_name();
 
 public:
-  ~table_esgs_by_host_by_event_name()
-  {}
+  ~table_esgs_by_host_by_event_name() = default;
 
 protected:
   void make_row(PFS_host *host, PFS_stage_class *klass);
diff --git a/storage/perfschema/table_esgs_by_thread_by_event_name.h b/storage/perfschema/table_esgs_by_thread_by_event_name.h
index 6ff677a95e2..9b0105345e5 100644
--- a/storage/perfschema/table_esgs_by_thread_by_event_name.h
+++ b/storage/perfschema/table_esgs_by_thread_by_event_name.h
@@ -110,8 +110,7 @@ protected:
   table_esgs_by_thread_by_event_name();
 
 public:
-  ~table_esgs_by_thread_by_event_name()
-  {}
+  ~table_esgs_by_thread_by_event_name() = default;
 
 protected:
   void make_row(PFS_thread *thread, PFS_stage_class *klass);
diff --git a/storage/perfschema/table_esgs_by_user_by_event_name.h b/storage/perfschema/table_esgs_by_user_by_event_name.h
index bc545c2438a..22e94c3de58 100644
--- a/storage/perfschema/table_esgs_by_user_by_event_name.h
+++ b/storage/perfschema/table_esgs_by_user_by_event_name.h
@@ -111,8 +111,7 @@ protected:
   table_esgs_by_user_by_event_name();
 
 public:
-  ~table_esgs_by_user_by_event_name()
-  {}
+  ~table_esgs_by_user_by_event_name() = default;
 
 protected:
   void make_row(PFS_user *user, PFS_stage_class *klass);
diff --git a/storage/perfschema/table_esgs_global_by_event_name.h b/storage/perfschema/table_esgs_global_by_event_name.h
index b8884355676..92f75f15048 100644
--- a/storage/perfschema/table_esgs_global_by_event_name.h
+++ b/storage/perfschema/table_esgs_global_by_event_name.h
@@ -74,8 +74,7 @@ protected:
   table_esgs_global_by_event_name();
 
 public:
-  ~table_esgs_global_by_event_name()
-  {}
+  ~table_esgs_global_by_event_name() = default;
 
 protected:
   void make_row(PFS_stage_class *klass);
diff --git a/storage/perfschema/table_esms_by_account_by_event_name.h b/storage/perfschema/table_esms_by_account_by_event_name.h
index 64f2053cff6..a3b7266c074 100644
--- a/storage/perfschema/table_esms_by_account_by_event_name.h
+++ b/storage/perfschema/table_esms_by_account_by_event_name.h
@@ -106,8 +106,7 @@ protected:
   table_esms_by_account_by_event_name();
 
 public:
-  ~table_esms_by_account_by_event_name()
-  {}
+  ~table_esms_by_account_by_event_name() = default;
 
 protected:
   void make_row(PFS_account *account, PFS_statement_class *klass);
diff --git a/storage/perfschema/table_esms_by_digest.h b/storage/perfschema/table_esms_by_digest.h
index 903b86110f6..f1de170d3ef 100644
--- a/storage/perfschema/table_esms_by_digest.h
+++ b/storage/perfschema/table_esms_by_digest.h
@@ -76,8 +76,7 @@ protected:
   table_esms_by_digest();
 
 public:
-  ~table_esms_by_digest()
-  {}
+  ~table_esms_by_digest() = default;
 
 protected:
   void make_row(PFS_statements_digest_stat*);
diff --git a/storage/perfschema/table_esms_by_host_by_event_name.h b/storage/perfschema/table_esms_by_host_by_event_name.h
index a6985b48149..1373d8058dd 100644
--- a/storage/perfschema/table_esms_by_host_by_event_name.h
+++ b/storage/perfschema/table_esms_by_host_by_event_name.h
@@ -106,8 +106,7 @@ protected:
   table_esms_by_host_by_event_name();
 
 public:
-  ~table_esms_by_host_by_event_name()
-  {}
+  ~table_esms_by_host_by_event_name() = default;
 
 protected:
   void make_row(PFS_host *host, PFS_statement_class *klass);
diff --git a/storage/perfschema/table_esms_by_thread_by_event_name.h b/storage/perfschema/table_esms_by_thread_by_event_name.h
index 72645d03389..d7111b9bc05 100644
--- a/storage/perfschema/table_esms_by_thread_by_event_name.h
+++ b/storage/perfschema/table_esms_by_thread_by_event_name.h
@@ -110,8 +110,7 @@ protected:
   table_esms_by_thread_by_event_name();
 
 public:
-  ~table_esms_by_thread_by_event_name()
-  {}
+  ~table_esms_by_thread_by_event_name() = default;
 
 protected:
   void make_row(PFS_thread *thread, PFS_statement_class *klass);
diff --git a/storage/perfschema/table_esms_by_user_by_event_name.h b/storage/perfschema/table_esms_by_user_by_event_name.h
index d1d1e5df85d..8b395ce9829 100644
--- a/storage/perfschema/table_esms_by_user_by_event_name.h
+++ b/storage/perfschema/table_esms_by_user_by_event_name.h
@@ -106,8 +106,7 @@ protected:
   table_esms_by_user_by_event_name();
 
 public:
-  ~table_esms_by_user_by_event_name()
-  {}
+  ~table_esms_by_user_by_event_name() = default;
 
 protected:
   void make_row(PFS_user *user, PFS_statement_class *klass);
diff --git a/storage/perfschema/table_esms_global_by_event_name.h b/storage/perfschema/table_esms_global_by_event_name.h
index b90c14c0c0f..60a298721d8 100644
--- a/storage/perfschema/table_esms_global_by_event_name.h
+++ b/storage/perfschema/table_esms_global_by_event_name.h
@@ -74,8 +74,7 @@ protected:
   table_esms_global_by_event_name();
 
 public:
-  ~table_esms_global_by_event_name()
-  {}
+  ~table_esms_global_by_event_name() = default;
 
 protected:
   void make_row(PFS_statement_class *klass);
diff --git a/storage/perfschema/table_events_stages.h b/storage/perfschema/table_events_stages.h
index ae8760cd953..b0a8d399090 100644
--- a/storage/perfschema/table_events_stages.h
+++ b/storage/perfschema/table_events_stages.h
@@ -102,8 +102,7 @@ protected:
 
   table_events_stages_common(const PFS_engine_table_share *share, void *pos);
 
-  ~table_events_stages_common()
-  {}
+  ~table_events_stages_common() = default;
 
   void make_row(PFS_events_stages *stage);
 
@@ -131,8 +130,7 @@ protected:
   table_events_stages_current();
 
 public:
-  ~table_events_stages_current()
-  {}
+  ~table_events_stages_current() = default;
 
 private:
   friend class table_events_stages_history;
@@ -165,8 +163,7 @@ protected:
   table_events_stages_history();
 
 public:
-  ~table_events_stages_history()
-  {}
+  ~table_events_stages_history() = default;
 
 private:
   /** Table share lock. */
@@ -196,8 +193,7 @@ protected:
   table_events_stages_history_long();
 
 public:
-  ~table_events_stages_history_long()
-  {}
+  ~table_events_stages_history_long() = default;
 
 private:
   /** Table share lock. */
diff --git a/storage/perfschema/table_events_statements.h b/storage/perfschema/table_events_statements.h
index cec28628f3e..8e4aafd8719 100644
--- a/storage/perfschema/table_events_statements.h
+++ b/storage/perfschema/table_events_statements.h
@@ -176,8 +176,7 @@ protected:
 
   table_events_statements_common(const PFS_engine_table_share *share, void *pos);
 
-  ~table_events_statements_common()
-  {}
+  ~table_events_statements_common() = default;
 
   void make_row_part_1(PFS_events_statements *statement,
                        sql_digest_storage *digest);
@@ -209,8 +208,7 @@ protected:
   table_events_statements_current();
 
 public:
-  ~table_events_statements_current()
-  {}
+  ~table_events_statements_current() = default;
 
 private:
   friend class table_events_statements_history;
@@ -245,8 +243,7 @@ protected:
   table_events_statements_history();
 
 public:
-  ~table_events_statements_history()
-  {}
+  ~table_events_statements_history() = default;
 
 private:
   /** Table share lock. */
@@ -278,8 +275,7 @@ protected:
   table_events_statements_history_long();
 
 public:
-  ~table_events_statements_history_long()
-  {}
+  ~table_events_statements_history_long() = default;
 
 private:
   /** Table share lock. */
diff --git a/storage/perfschema/table_events_waits.h b/storage/perfschema/table_events_waits.h
index 90c1d341e5d..94d8c9ff5bd 100644
--- a/storage/perfschema/table_events_waits.h
+++ b/storage/perfschema/table_events_waits.h
@@ -146,8 +146,7 @@ protected:
 
   table_events_waits_common(const PFS_engine_table_share *share, void *pos);
 
-  ~table_events_waits_common()
-  {}
+  ~table_events_waits_common() = default;
 
   void clear_object_columns();
   int make_table_object_columns(volatile PFS_events_waits *wait);
@@ -180,8 +179,7 @@ protected:
   table_events_waits_current();
 
 public:
-  ~table_events_waits_current()
-  {}
+  ~table_events_waits_current() = default;
 
 private:
   friend class table_events_waits_history;
@@ -213,8 +211,7 @@ protected:
   table_events_waits_history();
 
 public:
-  ~table_events_waits_history()
-  {}
+  ~table_events_waits_history() = default;
 
 private:
   /** Table share lock. */
@@ -243,8 +240,7 @@ protected:
   table_events_waits_history_long();
 
 public:
-  ~table_events_waits_history_long()
-  {}
+  ~table_events_waits_history_long() = default;
 
 private:
   /** Table share lock. */
diff --git a/storage/perfschema/table_events_waits_summary.h b/storage/perfschema/table_events_waits_summary.h
index 53f1bed7987..b38660fa439 100644
--- a/storage/perfschema/table_events_waits_summary.h
+++ b/storage/perfschema/table_events_waits_summary.h
@@ -80,8 +80,7 @@ protected:
   table_events_waits_summary_by_instance();
 
 public:
-  ~table_events_waits_summary_by_instance()
-  {}
+  ~table_events_waits_summary_by_instance() = default;
 
 private:
   /** Table share lock. */
diff --git a/storage/perfschema/table_ews_by_account_by_event_name.h b/storage/perfschema/table_ews_by_account_by_event_name.h
index 7cde09183e3..d4b4593a261 100644
--- a/storage/perfschema/table_ews_by_account_by_event_name.h
+++ b/storage/perfschema/table_ews_by_account_by_event_name.h
@@ -117,8 +117,7 @@ protected:
   table_ews_by_account_by_event_name();
 
 public:
-  ~table_ews_by_account_by_event_name()
-  {}
+  ~table_ews_by_account_by_event_name() = default;
 
 protected:
   void make_row(PFS_account *account, PFS_instr_class *klass);
diff --git a/storage/perfschema/table_ews_by_host_by_event_name.h b/storage/perfschema/table_ews_by_host_by_event_name.h
index 8ce44a96617..c9c96115855 100644
--- a/storage/perfschema/table_ews_by_host_by_event_name.h
+++ b/storage/perfschema/table_ews_by_host_by_event_name.h
@@ -117,8 +117,7 @@ protected:
   table_ews_by_host_by_event_name();
 
 public:
-  ~table_ews_by_host_by_event_name()
-  {}
+  ~table_ews_by_host_by_event_name() = default;
 
 protected:
   void make_row(PFS_host *host, PFS_instr_class *klass);
diff --git a/storage/perfschema/table_ews_by_thread_by_event_name.h b/storage/perfschema/table_ews_by_thread_by_event_name.h
index b67664bfced..3aabb78c5e2 100644
--- a/storage/perfschema/table_ews_by_thread_by_event_name.h
+++ b/storage/perfschema/table_ews_by_thread_by_event_name.h
@@ -116,8 +116,7 @@ protected:
   table_ews_by_thread_by_event_name();
 
 public:
-  ~table_ews_by_thread_by_event_name()
-  {}
+  ~table_ews_by_thread_by_event_name() = default;
 
 protected:
   void make_row(PFS_thread *thread, PFS_instr_class *klass);
diff --git a/storage/perfschema/table_ews_by_user_by_event_name.h b/storage/perfschema/table_ews_by_user_by_event_name.h
index f4f29534be4..7083cd5788d 100644
--- a/storage/perfschema/table_ews_by_user_by_event_name.h
+++ b/storage/perfschema/table_ews_by_user_by_event_name.h
@@ -117,8 +117,7 @@ protected:
   table_ews_by_user_by_event_name();
 
 public:
-  ~table_ews_by_user_by_event_name()
-  {}
+  ~table_ews_by_user_by_event_name() = default;
 
 protected:
   void make_row(PFS_user *user, PFS_instr_class *klass);
diff --git a/storage/perfschema/table_ews_global_by_event_name.h b/storage/perfschema/table_ews_global_by_event_name.h
index 8157d274112..62c5eefe46a 100644
--- a/storage/perfschema/table_ews_global_by_event_name.h
+++ b/storage/perfschema/table_ews_global_by_event_name.h
@@ -102,8 +102,7 @@ protected:
   table_ews_global_by_event_name();
 
 public:
-  ~table_ews_global_by_event_name()
-  {}
+  ~table_ews_global_by_event_name() = default;
 
 protected:
   void make_mutex_row(PFS_mutex_class *klass);
diff --git a/storage/perfschema/table_file_instances.h b/storage/perfschema/table_file_instances.h
index 5b44e63028e..6a62e1c4d73 100644
--- a/storage/perfschema/table_file_instances.h
+++ b/storage/perfschema/table_file_instances.h
@@ -72,8 +72,7 @@ private:
   table_file_instances();
 
 public:
-  ~table_file_instances()
-  {}
+  ~table_file_instances() = default;
 
 private:
   void make_row(PFS_file *pfs);
diff --git a/storage/perfschema/table_file_summary_by_event_name.h b/storage/perfschema/table_file_summary_by_event_name.h
index b8cb293cb07..17cc81e6686 100644
--- a/storage/perfschema/table_file_summary_by_event_name.h
+++ b/storage/perfschema/table_file_summary_by_event_name.h
@@ -73,8 +73,7 @@ private:
   table_file_summary_by_event_name();
 
 public:
-  ~table_file_summary_by_event_name()
-  {}
+  ~table_file_summary_by_event_name() = default;
 
 private:
   void make_row(PFS_file_class *klass);
diff --git a/storage/perfschema/table_file_summary_by_instance.h b/storage/perfschema/table_file_summary_by_instance.h
index 0e7ce6958b2..e49f966191b 100644
--- a/storage/perfschema/table_file_summary_by_instance.h
+++ b/storage/perfschema/table_file_summary_by_instance.h
@@ -81,8 +81,7 @@ private:
   table_file_summary_by_instance();
 
 public:
-  ~table_file_summary_by_instance()
-  {}
+  ~table_file_summary_by_instance() = default;
 
 private:
   void make_row(PFS_file *pfs);
diff --git a/storage/perfschema/table_host_cache.h b/storage/perfschema/table_host_cache.h
index 8add0b5049c..4b54865c7f5 100644
--- a/storage/perfschema/table_host_cache.h
+++ b/storage/perfschema/table_host_cache.h
@@ -125,8 +125,7 @@ protected:
   table_host_cache();
 
 public:
-  ~table_host_cache()
-  {}
+  ~table_host_cache() = default;
 
 private:
   void materialize(THD *thd);
diff --git a/storage/perfschema/table_hosts.h b/storage/perfschema/table_hosts.h
index 422b6449b25..57c5be31c6a 100644
--- a/storage/perfschema/table_hosts.h
+++ b/storage/perfschema/table_hosts.h
@@ -66,8 +66,7 @@ protected:
   table_hosts();
 
 public:
-  ~table_hosts()
-  {}
+  ~table_hosts() = default;
 
 private:
   virtual void make_row(PFS_host *pfs);
diff --git a/storage/perfschema/table_os_global_by_type.h b/storage/perfschema/table_os_global_by_type.h
index 2b9293ece06..6f6f1da5d17 100644
--- a/storage/perfschema/table_os_global_by_type.h
+++ b/storage/perfschema/table_os_global_by_type.h
@@ -110,8 +110,7 @@ protected:
   table_os_global_by_type();
 
 public:
-  ~table_os_global_by_type()
-  {}
+  ~table_os_global_by_type() = default;
 
 protected:
   void make_row(PFS_table_share *table_share);
diff --git a/storage/perfschema/table_performance_timers.h b/storage/perfschema/table_performance_timers.h
index 93210ac9882..ed583e33358 100644
--- a/storage/perfschema/table_performance_timers.h
+++ b/storage/perfschema/table_performance_timers.h
@@ -71,8 +71,7 @@ protected:
   table_performance_timers();
 
 public:
-  ~table_performance_timers()
-  {}
+  ~table_performance_timers() = default;
 
 private:
   /** Table share lock. */
diff --git a/storage/perfschema/table_session_account_connect_attrs.h b/storage/perfschema/table_session_account_connect_attrs.h
index 483001fcb91..9d39b6e5608 100644
--- a/storage/perfschema/table_session_account_connect_attrs.h
+++ b/storage/perfschema/table_session_account_connect_attrs.h
@@ -42,8 +42,7 @@ protected:
   table_session_account_connect_attrs();
 
 public:
-  ~table_session_account_connect_attrs()
-  {}
+  ~table_session_account_connect_attrs() = default;
 
 protected:
   virtual bool thread_fits(PFS_thread *thread);
diff --git a/storage/perfschema/table_session_connect_attrs.h b/storage/perfschema/table_session_connect_attrs.h
index 927c3a92af2..f7939fd02d5 100644
--- a/storage/perfschema/table_session_connect_attrs.h
+++ b/storage/perfschema/table_session_connect_attrs.h
@@ -42,8 +42,7 @@ protected:
   table_session_connect_attrs();
 
 public:
-  ~table_session_connect_attrs()
-  {}
+  ~table_session_connect_attrs() = default;
 
 private:
   /** Table share lock. */
diff --git a/storage/perfschema/table_setup_actors.h b/storage/perfschema/table_setup_actors.h
index 6bfc480a9c5..28660dacc6a 100644
--- a/storage/perfschema/table_setup_actors.h
+++ b/storage/perfschema/table_setup_actors.h
@@ -88,8 +88,7 @@ protected:
   table_setup_actors();
 
 public:
-  ~table_setup_actors()
-  {}
+  ~table_setup_actors() = default;
 
 private:
   void make_row(PFS_setup_actor *actor);
diff --git a/storage/perfschema/table_setup_consumers.h b/storage/perfschema/table_setup_consumers.h
index 90da55920c6..9e39b932829 100644
--- a/storage/perfschema/table_setup_consumers.h
+++ b/storage/perfschema/table_setup_consumers.h
@@ -73,8 +73,7 @@ protected:
   table_setup_consumers();
 
 public:
-  ~table_setup_consumers()
-  {}
+  ~table_setup_consumers() = default;
 
 private:
   /** Table share lock. */
diff --git a/storage/perfschema/table_setup_instruments.h b/storage/perfschema/table_setup_instruments.h
index cd3715cfe55..ff52d8fc0c3 100644
--- a/storage/perfschema/table_setup_instruments.h
+++ b/storage/perfschema/table_setup_instruments.h
@@ -105,8 +105,7 @@ protected:
   table_setup_instruments();
 
 public:
-  ~table_setup_instruments()
-  {}
+  ~table_setup_instruments() = default;
 
 private:
   void make_row(PFS_instr_class *klass);
diff --git a/storage/perfschema/table_setup_objects.h b/storage/perfschema/table_setup_objects.h
index 570acc865ad..b5f86c87ea1 100644
--- a/storage/perfschema/table_setup_objects.h
+++ b/storage/perfschema/table_setup_objects.h
@@ -91,8 +91,7 @@ protected:
   table_setup_objects();
 
 public:
-  ~table_setup_objects()
-  {}
+  ~table_setup_objects() = default;
 
 private:
   void make_row(PFS_setup_object *pfs);
diff --git a/storage/perfschema/table_setup_timers.h b/storage/perfschema/table_setup_timers.h
index d591f3e0b67..24180221e1e 100644
--- a/storage/perfschema/table_setup_timers.h
+++ b/storage/perfschema/table_setup_timers.h
@@ -71,8 +71,7 @@ protected:
   table_setup_timers();
 
 public:
-  ~table_setup_timers()
-  {}
+  ~table_setup_timers() = default;
 
 private:
   /** Table share lock. */
diff --git a/storage/perfschema/table_socket_instances.h b/storage/perfschema/table_socket_instances.h
index 41b5ee3fd21..1be68bca557 100644
--- a/storage/perfschema/table_socket_instances.h
+++ b/storage/perfschema/table_socket_instances.h
@@ -84,8 +84,7 @@ private:
   table_socket_instances();
 
 public:
-  ~table_socket_instances()
-  {}
+  ~table_socket_instances() = default;
 
 private:
   void make_row(PFS_socket *pfs);
diff --git a/storage/perfschema/table_socket_summary_by_event_name.h b/storage/perfschema/table_socket_summary_by_event_name.h
index 4f679d89b09..36b01d9fd49 100644
--- a/storage/perfschema/table_socket_summary_by_event_name.h
+++ b/storage/perfschema/table_socket_summary_by_event_name.h
@@ -74,8 +74,7 @@ private:
   table_socket_summary_by_event_name();
 
 public:
-  ~table_socket_summary_by_event_name()
-  {}
+  ~table_socket_summary_by_event_name() = default;
 
 private:
   void make_row(PFS_socket_class *socket_class);
diff --git a/storage/perfschema/table_socket_summary_by_instance.h b/storage/perfschema/table_socket_summary_by_instance.h
index a9eab8d18b6..3c6fe25d8e8 100644
--- a/storage/perfschema/table_socket_summary_by_instance.h
+++ b/storage/perfschema/table_socket_summary_by_instance.h
@@ -77,8 +77,7 @@ private:
   table_socket_summary_by_instance();
 
 public:
-  ~table_socket_summary_by_instance()
-  {}
+  ~table_socket_summary_by_instance() = default;
 
 private:
   void make_row(PFS_socket *pfs);
diff --git a/storage/perfschema/table_sync_instances.h b/storage/perfschema/table_sync_instances.h
index 6f7e1bf5523..0d60090022e 100644
--- a/storage/perfschema/table_sync_instances.h
+++ b/storage/perfschema/table_sync_instances.h
@@ -76,8 +76,7 @@ private:
   table_mutex_instances();
 
 public:
-  ~table_mutex_instances()
-  {}
+  ~table_mutex_instances() = default;
 
 private:
   void make_row(PFS_mutex *pfs);
@@ -133,8 +132,7 @@ private:
   table_rwlock_instances();
 
 public:
-  ~table_rwlock_instances()
-  {}
+  ~table_rwlock_instances() = default;
 
 private:
   void make_row(PFS_rwlock *pfs);
@@ -184,8 +182,7 @@ private:
   table_cond_instances();
 
 public:
-  ~table_cond_instances()
-  {}
+  ~table_cond_instances() = default;
 
 private:
   void make_row(PFS_cond *pfs);
diff --git a/storage/perfschema/table_threads.h b/storage/perfschema/table_threads.h
index 841b8102bca..029ab9634c6 100644
--- a/storage/perfschema/table_threads.h
+++ b/storage/perfschema/table_threads.h
@@ -101,8 +101,7 @@ protected:
   table_threads();
 
 public:
-  ~table_threads()
-  {}
+  ~table_threads() = default;
 
 private:
   virtual void make_row(PFS_thread *pfs);
diff --git a/storage/perfschema/table_tiws_by_index_usage.h b/storage/perfschema/table_tiws_by_index_usage.h
index a284bc7f0bc..ac5d628199f 100644
--- a/storage/perfschema/table_tiws_by_index_usage.h
+++ b/storage/perfschema/table_tiws_by_index_usage.h
@@ -104,8 +104,7 @@ protected:
   table_tiws_by_index_usage();
 
 public:
-  ~table_tiws_by_index_usage()
-  {}
+  ~table_tiws_by_index_usage() = default;
 
 protected:
   void make_row(PFS_table_share *table_share, uint index);
diff --git a/storage/perfschema/table_tiws_by_table.h b/storage/perfschema/table_tiws_by_table.h
index 7427ca797fa..b51398d6108 100644
--- a/storage/perfschema/table_tiws_by_table.h
+++ b/storage/perfschema/table_tiws_by_table.h
@@ -74,8 +74,7 @@ protected:
   table_tiws_by_table();
 
 public:
-  ~table_tiws_by_table()
-  {}
+  ~table_tiws_by_table() = default;
 
 protected:
   void make_row(PFS_table_share *table_share);
diff --git a/storage/perfschema/table_tlws_by_table.h b/storage/perfschema/table_tlws_by_table.h
index b5872a07762..8aabfef145a 100644
--- a/storage/perfschema/table_tlws_by_table.h
+++ b/storage/perfschema/table_tlws_by_table.h
@@ -74,8 +74,7 @@ protected:
   table_tlws_by_table();
 
 public:
-  ~table_tlws_by_table()
-  {}
+  ~table_tlws_by_table() = default;
 
 protected:
   void make_row(PFS_table_share *table_share);
diff --git a/storage/perfschema/table_users.h b/storage/perfschema/table_users.h
index 912f0f43714..8121262b040 100644
--- a/storage/perfschema/table_users.h
+++ b/storage/perfschema/table_users.h
@@ -66,8 +66,7 @@ protected:
   table_users();
 
 public:
-  ~table_users()
-  {}
+  ~table_users() = default;
 
 private:
   virtual void make_row(PFS_user *pfs);