diff options
| author | Jan Lindström <jplindst@mariadb.org> | 2014-11-21 13:27:36 +0200 |
|---|---|---|
| committer | Jan Lindström <jplindst@mariadb.org> | 2014-11-21 13:27:36 +0200 |
| commit | b0febdb66e6f2a8c545995daff9f300acea297a0 (patch) | |
| tree | 104664e49cff900767eb1c0c7799070e67784fd1 /storage | |
| parent | 48f4961a12919405a719c951630a8b804e685997 (diff) | |
| download | mariadb-git-b0febdb66e6f2a8c545995daff9f300acea297a0.tar.gz | |
MDEV-7084: innodb index stats inadequate using constant innodb_stats_sample_pages
Use traditional statistics estimation by default (innodb-stats-traditional=true).
There could be performance regression for customers if there is a lot of
open table operations.
Diffstat (limited to 'storage')
| -rw-r--r-- | storage/innobase/handler/ha_innodb.cc | 4 | ||||
| -rw-r--r-- | storage/innobase/srv/srv0srv.c | 4 | ||||
| -rw-r--r-- | storage/xtradb/handler/ha_innodb.cc | 4 | ||||
| -rw-r--r-- | storage/xtradb/srv/srv0srv.c | 4 |
4 files changed, 8 insertions, 8 deletions
diff --git a/storage/innobase/handler/ha_innodb.cc b/storage/innobase/handler/ha_innodb.cc index 4dd4b2d0d12..450e89ebb87 100644 --- a/storage/innobase/handler/ha_innodb.cc +++ b/storage/innobase/handler/ha_innodb.cc @@ -11746,8 +11746,8 @@ static MYSQL_SYSVAR_ULONGLONG(stats_modified_counter, srv_stats_modified_counter static MYSQL_SYSVAR_BOOL(stats_traditional, srv_stats_sample_traditional, PLUGIN_VAR_RQCMDARG, - "Enable traditional statistic calculation based on number of configured pages (default false)", - NULL, NULL, FALSE); + "Enable traditional statistic calculation based on number of configured pages (default true)", + NULL, NULL, TRUE); static MYSQL_SYSVAR_BOOL(adaptive_hash_index, btr_search_enabled, PLUGIN_VAR_OPCMDARG, diff --git a/storage/innobase/srv/srv0srv.c b/storage/innobase/srv/srv0srv.c index bf91a3629cd..49e5133df45 100644 --- a/storage/innobase/srv/srv0srv.c +++ b/storage/innobase/srv/srv0srv.c @@ -754,8 +754,8 @@ static ulint srv_meter_foreground[SRV_MASTER + 1]; UNIV_INTERN unsigned long long srv_stats_modified_counter = 0; /* Enable traditional statistic calculation based on number of configured -pages default false. */ -UNIV_INTERN my_bool srv_stats_sample_traditional = FALSE; +pages default true. */ +UNIV_INTERN my_bool srv_stats_sample_traditional = TRUE; /* The following values give info about the activity going on in the database. They are protected by the server mutex. The arrays diff --git a/storage/xtradb/handler/ha_innodb.cc b/storage/xtradb/handler/ha_innodb.cc index b70b281b957..e4f5e088b9d 100644 --- a/storage/xtradb/handler/ha_innodb.cc +++ b/storage/xtradb/handler/ha_innodb.cc @@ -13114,8 +13114,8 @@ static MYSQL_SYSVAR_ULONGLONG(stats_modified_counter, srv_stats_modified_counter static MYSQL_SYSVAR_BOOL(stats_traditional, srv_stats_sample_traditional, PLUGIN_VAR_RQCMDARG, - "Enable traditional statistic calculation based on number of configured pages (default false)", - NULL, NULL, FALSE); + "Enable traditional statistic calculation based on number of configured pages (default true)", + NULL, NULL, TRUE); static MYSQL_SYSVAR_ULINT(stats_auto_update, srv_stats_auto_update, PLUGIN_VAR_RQCMDARG, diff --git a/storage/xtradb/srv/srv0srv.c b/storage/xtradb/srv/srv0srv.c index faaf435d174..55d08ceb26c 100644 --- a/storage/xtradb/srv/srv0srv.c +++ b/storage/xtradb/srv/srv0srv.c @@ -416,8 +416,8 @@ UNIV_INTERN ulong srv_sys_stats_root_page = 0; UNIV_INTERN unsigned long long srv_stats_modified_counter = 0; /* Enable traditional statistic calculation based on number of configured -pages default false. */ -UNIV_INTERN my_bool srv_stats_sample_traditional = FALSE; +pages default true. */ +UNIV_INTERN my_bool srv_stats_sample_traditional = TRUE; UNIV_INTERN ibool srv_use_doublewrite_buf = TRUE; UNIV_INTERN ibool srv_use_atomic_writes = FALSE; |