BUG#32050 - table logging gone wrong.

INSERT/UPDATE against CSV table created by MySQL earlier than 5.1.23
with NULL-able column results in server crash in debug builds.

Starting with 5.1.23 CSV doesn't permit creation of NULL-able columns,
but it is still possible to get such table from older MySQL versions.

Fixed by removing excessive DBUG_ASSERT().


scripts/mysql_system_tables_fix.sql:
  Starting with 5.1.23 CSV doesn't permit creation of NULL-able columns.
  Alter system CSV tables structure so that all columns are NOT NULL.
storage/csv/ha_tina.cc:
  Starting with 5.1.23 CSV doesn't permit creation of NULL-able columns,
  but it is still possible to get such table from older MySQL versions.
  
  Removed excessive DBUG_ASSERT().

1 files changed, 0 insertions, 8 deletions

diff --git a/storage/csv/ha_tina.cc b/storage/csv/ha_tina.cc
index 6a87b8ecc72..75c3f70dec4 100644
--- a/storage/csv/ha_tina.cc
+++ b/storage/csv/ha_tina.cc
@@ -472,14 +472,6 @@ int ha_tina::encode_quote(uchar *buf)
     const char *ptr;
     const char *end_ptr;
     const bool was_null= (*field)->is_null();
-
-    /*
-      CSV does not support nulls. ::create() prevents creation of a table
-      with nullable columns so if we encounter them here, there is a bug.
-      This may only occur if the frm was created by an older version of
-      mysqld which permitted table creation with nullable columns.
-    */
-    DBUG_ASSERT(!(*field)->maybe_null());
     
     /*
       assistance for backwards compatibility in production builds.