Cleanups during review of new code

Ensure mysql_close() is called if mysql_set_character_set() fails


libmysql/libmysql.c:
  Indentation cleanup
mysql-test/r/select.result:
  Fix bad merge & align code with 4.1
mysql-test/r/type_newdecimal.result:
  Added test of extreme case
mysql-test/t/select.test:
  Fix bad merge & align code with 4.1
mysql-test/t/type_newdecimal.test:
  Added test of extreme case
mysys/charset.c:
  Removed not used variable
mysys/default.c:
  Simplify code
sql-common/client.c:
  Ensure mysql_close() is called if mysql_set_character_set() fails
sql/log.cc:
  strmov(strmov())  -> strxmov()
sql/sp.cc:
  Indentation fixes
sql/sql_acl.cc:
  Indentation fixes
sql/sql_base.cc:
  Added commments
  Moved variable to inner block
sql/sql_show.cc:
  Simple optimization (removed loop variable)
sql/sql_trigger.cc:
  strmov(strmov())  -> strxmov()
strings/decimal.c:
  Indentation fixes

1 files changed, 5 insertions, 2 deletions

diff --git a/strings/decimal.c b/strings/decimal.c
index 1d75502f0da..ca92ace92e1 100644
--- a/strings/decimal.c
+++ b/strings/decimal.c
@@ -745,14 +745,17 @@ int decimal_shift(decimal_t *dec, int shift)
     new_point= ROUND_UP(new_point) - 1;
 
   if (new_point > end)
+  {
     do
     {
       dec->buf[new_point]=0;
-    }while (--new_point > end);
+    } while (--new_point > end);
+  }
   else
+  {
     for (; new_point < beg; new_point++)
       dec->buf[new_point]= 0;
-
+  }
   dec->intg= digits_int;
   dec->frac= digits_frac;
   return err;