summaryrefslogtreecommitdiff
path: root/strings
diff options
context:
space:
mode:
authorAlexander Barkov <bar@mariadb.com>2019-12-16 12:57:08 +0400
committerAlexander Barkov <bar@mariadb.com>2019-12-16 12:57:08 +0400
commitfc860d3fa3bc854fbe6aab9179d7a4aaf6eb9edf (patch)
tree0d7a45f7faa9748af710ede26d04aa27da2c2d5a /strings
parent794911a27a14ea83eda054cf34d94b43191aa19e (diff)
downloadmariadb-git-fc860d3fa3bc854fbe6aab9179d7a4aaf6eb9edf.tar.gz
MDEV-21065 UNIQUE constraint causes a query with string comparison to omit a row in the result set
Diffstat (limited to 'strings')
-rw-r--r--strings/ctype-simple.c3
-rw-r--r--strings/my_strtoll10.c17
2 files changed, 14 insertions, 6 deletions
diff --git a/strings/ctype-simple.c b/strings/ctype-simple.c
index ba446a7df54..e5a1471cf63 100644
--- a/strings/ctype-simple.c
+++ b/strings/ctype-simple.c
@@ -1399,7 +1399,8 @@ my_strntoull10rnd_8bit(CHARSET_INFO *cs __attribute__((unused)),
int shift= 0, digits= 0, negative, addon;
/* Skip leading spaces and tabs */
- for ( ; str < end && (*str == ' ' || *str == '\t') ; str++);
+ for ( ; str < end && my_isspace(&my_charset_latin1, *str) ; )
+ str++;
if (str >= end)
goto ret_edom;
diff --git a/strings/my_strtoll10.c b/strings/my_strtoll10.c
index 89450f15c9f..01c3697dcdf 100644
--- a/strings/my_strtoll10.c
+++ b/strings/my_strtoll10.c
@@ -98,18 +98,25 @@ longlong my_strtoll10(const char *nptr, char **endptr, int *error)
if (endptr)
{
end= *endptr;
- while (s != end && (*s == ' ' || *s == '\t'))
+ /* Skip leading spaces */
+ for ( ; s < end && my_isspace(&my_charset_latin1, *s) ; )
s++;
+
if (s == end)
goto no_conv;
}
else
{
endptr= &dummy; /* Easier end test */
- while (*s == ' ' || *s == '\t')
- s++;
- if (!*s)
- goto no_conv;
+ /* Skip leading spaces */
+ for ( ; ; s++)
+ {
+ if (!*s)
+ goto no_conv;
+ if (!my_isspace(&my_charset_latin1, *s))
+ break;
+ }
+
/* This number must be big to guard against a lot of pre-zeros */
end= s+65535; /* Can't be longer than this */
}