summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Merge 10.9 into 10.10Marko Mäkelä2022-12-14225-4469/+2265
|\
| * Merge 10.8 into 10.9Marko Mäkelä2022-12-144-0/+7
| |\
| | * Merge 10.7 into 10.8Marko Mäkelä2022-12-144-0/+7
| | |\
| | | * Merge 10.6 into 10.7Marko Mäkelä2022-12-143-0/+5
| | | |\
| | | | * Merge branch '10.5' into 10.6Daniel Black2022-12-143-0/+5
| | | | |\
| | | | | * MDEV-30172 re-disable galera testsDaniel Black2022-12-143-1/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | galera_sr.GCF-1060 'innodb' w2 [ fail ] timeout after 900 seconds galera_3nodes.galera_ssl_reload At line 50: mysql_shutdown failed galera_3nodes.galera_ssl_reload : MDEV-30172 At line 50: mysql_shutdown failed galera_3nodes.GCF-354 : mysqltest: At line 39: query 'DROP TABLE test.t1' failed: 1047: WSREP has not yet prepared node for application use galera_3nodes.GCF-354 : mysqltest: At line 30: query 'INSERT INTO test.t1 values (1)' failed: 1180: Got error 6 "No such device or address" galera_wan : [ERROR] WSREP: /home/buildbot/buildbot/build/gcs/src/gcs_state_msg.cpp:gcs_state_msg_get_quorum():947: Failed to establish quorum.
| | | * | | After-merge fixMarko Mäkelä2022-12-141-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | This fixes up 25b91c3f13affc1b58169240894b206ff34b1db3
| * | | | | Merge 10.8 into 10.9Marko Mäkelä2022-12-13227-4469/+2337
| |\ \ \ \ \ | | |/ / / /
| | * | | | Merge 10.7 into 10.8Marko Mäkelä2022-12-13227-4469/+2337
| | |\ \ \ \ | | | |/ / /
| | | * | | Merge 10.6 into 10.7Marko Mäkelä2022-12-13227-4470/+2337
| | | |\ \ \ | | | | |/ /
| | | | * | Merge 10.5 into 10.6Marko Mäkelä2022-12-13178-473/+1980
| | | | |\ \ | | | | | |/
| | | | | * Merge 10.4 into 10.5Marko Mäkelä2022-12-13179-475/+1889
| | | | | |\
| | | | | | * Merge 10.3 into 10.4Marko Mäkelä2022-12-13171-468/+1860
| | | | | | |\
| | | | | | | * MDEV-29814: galera_var_notify_ssl_ipv6 causes testing system to hangJulius Goryavsky2022-12-097-88/+161
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This commit fixes the test system hanging due to the galera_var_notify_ssl_ipv6 test and also brings the wsrep_notify[_ssl].sh files in line with each other between the user template and the mtr suite. Quotes are also added here to avoid problems if the user specifies the value of one of the variables at the beginning of the file containing shell-specific characters, for example, if the password or username specified in the PSWD and USER variables will contain the "$" character. Also fixed an issue with automatic --ssl-verify-server-cert option substitution when the corresponding value is set by the user to "1" or "on". Also fixed some tests here to avoid joining one of the nodes to another cluster when the nodes are restarted from the mtr side, which can lead to random failures when testing with buildbot.
| | | | | | | * MDEV-29144 ER_TABLE_SCHEMA_MISMATCH or crash on DISCARD/IMPORTMarko Mäkelä2022-12-097-7/+110
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | mysql_discard_or_import_tablespace(): On successful ALTER TABLE...DISCARD TABLESPACE, evict the table handle from the table definition cache, so that ha_innobase::close() will be invoked, like InnoDB expects to be the case. This will avoid an assertion failure ut_a(table->get_ref_count() == 0) during IMPORT TABLESPACE. ha_innobase::open(): Do not issue any ER_TABLESPACE_DISCARDED warning. Member functions for DML will do that. ha_innobase::truncate(), ha_innobase::check_if_supported_inplace_alter(): Issue ER_TABLESPACE_DISCARDED warnings, to compensate for the removal of the warning in ha_innobase::open(). row_quiesce_write_indexes(): Only write information about committed indexes. The ALTER TABLE t NOWAIT ADD INDEX(c) in the nondeterministic test case will most of the time fail due to a metadata lock (MDL) timeout and leave behind an uncommitted index. Reviewed by: Sergei Golubchik
| | | | | | | * MDEV-30150 ST_GeomFromGeoJSON, 'geometry' before 'type: feature' errorDaniel Black2022-12-093-1/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The geometry type requires Type:"Feature" but the feature need not be first in the JSON structure. Adjust code to return an error if geometry isn't a JSON object, but continue parsing searching for Type: "Feature" to trigger the geometry parsing. Thanks Derick Magnusen for the bug report.
| | | | | | | * MDEV-30162 Fix occasional "Permission denied" on Windows caused by buggy 3rd ↵Vladislav Vaintroub2022-12-076-107/+194
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | party Add retry logic for CreateFile, DeleteFile, or MoveFile when GetLastError() is ERROR_SHARING_VIOLATION.
| | | | | | | * MDEV-29636 Assertion `part_share->auto_inc_initialized || ↵Nayuta Yanagisawa2022-12-078-1/+87
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | !can_use_for_auto_inc_init()' failed in ha_partition::set_auto_increment_if_higher upon REPLACE with partition pruning The bug is caused by a similar mechanism as MDEV-21027. The function, check_insert_or_replace_autoincrement, failed to open all the partitions on REPLACE SELECT statements and it results in the assertion error.
| | | | | | | * dgcov: parsing without dot to get specific versionAnel Husakovic2022-12-051-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - Regression introduced 7baf24a0f8e9491a55 for multidigit gcc dump. There is no dot in `dumpversion`. ``` $ gcc -dumpversion 10 ``` Otherwise it will fail and not produce the output ``` Running dgcov Name "IO::Uncompress::Gunzip::GunzipError" used only once: possible typo at ./dgcov.pl line 197. Cannot parse gcc -dumpversion: 9 ``` - The warning `once` is always generated: ``` Running dgcov Name "IO::Uncompress::Gunzip::GunzipError" used only once: possible typo at ./dgcov.pl line 197. <number> ``` Suppresing the line `Name "IO::Uncompress::Gunzip::GunzipError" used only once: possible typo at ./dgcov.pl line 197.` with the patch. - Reviewed by: <>
| | | | | | | * dgcov: also remove rpm dependency on IO::Uncompress::GunzipSergei Golubchik2022-12-041-5/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | and enable option bundling
| | | | | | | * MDEV-26102 followupSergei Golubchik2022-12-022-15/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * update README * fix version regex to support versions with two digits * die if the version cannot be parsed * support gcc versions 11+ * require JSON::PP not use, to avoid introducing new rpm dependency into MariaDB-test
| | | | | | | * MDEV-26102 dgcov: add support for *.gcda.gcov.json.gz files of gcov 9.1+Anel Husakovic2022-12-021-18/+36
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - Script covers situation for gcov (gcc) < 9 with non-json format of generated files as well as for gcov (gcc) >=8 with json generated format Reviewed by: serg@mariadb.com
| | | | | | | * fix more sporadic failures on main.killSergei Golubchik2022-12-021-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | sometimes `KILL QUERY ID @id` was executed before the previous `send SELECT SLEEP(1000)` has reached the parser. As the statement resets the kill status before execution, the effect of the KILL was ignored.
| | | | | | | * MDEV-30082 View definition losing brackets changes semantics of the query ↵Sergei Golubchik2022-12-024-0/+37
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | and causes wrong result Item_func_not_all::print() either uses Item_func::print() or directly invokes args[0]->print(). Thus the precedence should be either the one of Item_func or of args[0]. Item_allany_subselect::print() prints args[0], then a comparison op, then a subquery. That is, the precedence should be the one of a comparison.
| | | | | | | * try harder to reject not strictly deterministic vcols in indexes/storedSergei Golubchik2022-12-024-6/+42
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | detect non-determinism in vcol of vcol, like: create table t1 (a int, b real as (rand()), c real as (b) stored);
| | | | | | | * MDEV-30016 Virtual columns do not support autoincrement columnsSergei Golubchik2022-12-028-7/+55
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | change vcol_upgrade test to use stored gcols
| | | | | | | * cleanup: VCOL_NOT_VIRTUAL->VCOL_NEXTVALSergei Golubchik2022-12-026-8/+15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | rename to stress that is a specific hack for Item_func_nextval and should not be used for other items. If a vcol uses Item_func_nextval, a corresponding table for the sequence should be added to the prelocking list (in that sense NEXTVAL is not simply a function, but more like a subquery), see add_internal_tables() in DML_prelocking_strategy::handle_table(). At the moment it is only implemented for DEFAULT, not for GENERATED ALWAYS AS, thus the VCOL_NEXTVAL hack.
| | | | | | | * MDEV-30056 Impossible to export column grantsSergei Golubchik2022-12-0221-92/+91
| | | | | | | |
| | | | | | | * MDEV-30036 NULL pointer dereference in ↵Sergei Golubchik2022-12-022-22/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | partition_info::set_partition_bitmaps_from_table remove dead code
| | | | | | | * fix embedded startup with no command line argumentsSergei Golubchik2022-12-021-9/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | &fake_argv cannot be cast to char*** this causes a crash when resolving
| | | | | | | * MDEV-30066 (limit + offset) union all (...) limit = incorrect resultSergei Golubchik2022-12-023-5/+32
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | select_union_direct::send_data() only sends a record when the LIMIT ... OFFSET clause of the individual select won't skip it. Thus, select_union_direct::send_data() should not do any actions related to a sending a record if the offset of a select isn't reached yet
| | | | | | | * cleanup: union.testSergei Golubchik2022-12-022-25/+20
| | | | | | | |
| | | | | | | * MDEV-28855 SEGV around dict_free_vc_templ during DROP INDEXSergei Golubchik2022-12-021-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | protect shared dict_table_t::vc_templ with a mutex, same as in ha_innobase::open
| | | | | | | * cleanup: clarify innobase_init_vc_templ usageSergei Golubchik2022-12-022-11/+4
| | | | | | | |
| | | | | | | * MDEV-28643: view protocol fails due to different column nameOleksandr Byelkin2022-12-022-7/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Decent name given to the column.
| | | | | | | * MDEV-28696 View created as "select b''; " references invalid table(s) or ↵Alexander Barkov2022-12-025-3/+37
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | column(s) or function(s) or definer/invoker of view lack rights to use them
| | | | | | | * MDEV-30112 ASAN errors in Item_ident::print / generate_partition_syntaxbb-10.3-midenokAleksey Midenkov2022-12-013-0/+25
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Like in MDEV-16110 we must release items allocated on thd->mem_root by reopening the table. MDEV-16290 relocated MDEV-16110 fix in 10.5 so it works for MDEV-28576 as well. 10.3 without MDEV-16290 now duplicates this fix.
| | | | | | | * MDEV-30023 Revoking Privilege on the Column Yields the Errorbb-10.3-vicentiuVicențiu Ciorbaru2022-11-303-2/+48
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The change from MDEV-29465 exposed a flaw in replace_column_table where again we were not properly updating the column-level bits. replace_table_table was changed in MDEV-29465 to properly update grant_table->init_cols, however replace_column_table still only modified grant_column->rights when the GRANT_COLUMN already existed. This lead to a missmatch between GRANT_COLUMN::init_rights and GRANT_COLUMN::rights, *if* the GRANT_COLUMN already existed. As an example: GRANT SELECT (col1) ... Here: For col1 GRANT_COLUMN::init_rights and GRANT_COLUMN::rights are set to 1 (SELECT) in replace_column_table. GRANT INSERT (col1) ... Here, without this patch GRANT_COLUMN::init_rights is still 1 and GRANT_COLUMN::rights is 3 (SELECT_PRIV | INSERT_PRIV) Finally, if before this patch, one does: REVOKE SELECT (col1) ... replace_table_table will see that init_rights loses bit 1 thus it considers there are no more rights granted on that particular table. This prompts the whole GRANT_TABLE to be removed via the first revoke, when the GRANT_COLUMN corresponding to it should still have init_rights == 2. By also updating replace_column_table to keep init_rights in sync properly, the issue is resolved. Reviewed by <serg@mariadb.com>
| | | | | | | * MDEV-28299: Server crashes in XINDXS::Range/CntIndexRange (Connect engine)Anel Husakovic2022-11-293-0/+66
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - Bug happens only in case when the range function on empty key single column index (XINDEXS) is used. - Solution is to return with empty result in this scenario. Reviewed by: <>
| | | | | | | * [MDEV-30002] Skip bad_startup_options test when running as root (#2344)Robin Newhouse2022-11-291-0/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Commit 32158be added a new test `bad_startup_options`. This test fails if run as root, which is common on many CI systems. This test should include `not_as_root.inc` so it is skipped, just like all other similar tests in MariaDB. All new code of the whole pull request, including one or several files that are either new files or modified ones, are contributed under the BSD-new license. I am contributing on behalf of my employer Amazon Web Services, Inc.
| | | | | | | * Add a global suppression for O_DIRECT failuresMarko Mäkelä2022-11-292-6/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixes up commit b8ad6fbd95830b61d282abc1167300fff261be7e
| | | | | | | * Fixed warning from innodb.create_isl_with_direct if have_symlink is disabledbb-10.3-montyMonty2022-11-291-6/+5
| | | | | | | |
| | | | | | | * Safety fixMonty2022-11-291-3/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Ensure that all memory allocated by TABLE_LIST::change_refs_to_fields() is in the same memory root!
| | | | | | | * Fixed the BUILD scripts to work outside of a git repositoryMonty2022-11-291-4/+8
| | | | | | | |
| | | | | | | * Enable valgrind for replication testMonty2022-11-294-2/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The following tests are disabled when running --valgrding without --big: - rpl.rpl_ssl - rpl.rpl_semi_sync_event - All encryption test (which includes have_file_key_management.inc)
| | | | | | | * MDEV-16735 Ensure mysql_upgrade works when changing alter_algorithmChristian Gonzalez2022-11-293-1/+73
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | MDEV-16735 describes how mysql_upgrade fails when alter_algorithm is set to a value different than 'DEFAULT'/'COPY'. It was marked as fixed by 0ee0868, but the fix didn't covered the possibility of having the global value of alter_algorithm set to something different than 'DEFAULT'/'COPY'. To ensure that the upgrade process works properly regardless the global value of alter_altorithm, this commit force it's value to 'DEFAULT' (note the quotes) for the mysql_upgrade session. All new code of the whole pull request, including one or several files that are either new files or modified ones, are contributed under the BSD-new license. I am contributing on behalf of my employer Amazon Web Services, Inc.
| | | | | | | * MDEV-29348 rpl.rpl_rewrt_db test fails with [gdb,manual-gdb] with wrong parsingAnel Husakovic2022-11-281-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Reviewer: <serg@mariadb.com> Closes PR #2244
| | | | | | | * MDEV-28996 ASAN errors in String::q_append / spider_string::q_append / ↵Nayuta Yanagisawa2022-11-284-9/+90
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | spider_db_mbase_util::open_item_func The server crashed due to the stack-use-after-scope on tmp_str. tmp_str will be used later so should not point to the local buffer.
| | | | | | | * MDEV-29855 Crash with SPIDER_DIRECT_SQL and spider_udf_ds_use_real_table=1Nayuta Yanagisawa2022-11-244-11/+77
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The crash occurs because of the following call of TABLE_LIST::init_one_table(): table_list.init_one_table( &table_list.db, &table_list.table_name, 0, TL_WRITE); One should not pass table_list.db and table_list.table_name to the function because it update the very members internally. The function is called previously, and there is no need to call it again. So, simply removing the call will resolve the problem.
| | | | | | | * MDEV-29169 Using MATCH returns NULL for Virtual ColumnNikita Malyavin2022-11-233-0/+38
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Virtual column values are updated in handler in reading commands, like ha_index_next, etc. This was missing for ha_ft_read. handler::ha_ft_read: add table->update_virtual_fields() call